Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The crosspoint limit, GraphSpace defaults, compute-limit inheritance, update requirements and PD-first deletion text match GraphSpaceAPI, GraphManager.dropGraphSpace and PD ConfigService on master. One wording issue in the LOADING ownership intro, in both languages.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The crosspoint limit, GraphSpace create defaults, compute-limit update semantics, PD-first deletion guidance and LOADING ownership text match GraphSpaceAPI, GraphManager.dropGraphSpace, PD ConfigService and GraphsAPI on master, and the earlier LOADING wording comment is fixed. One time-anchored sentence remains under the create table, in both languages.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Score: 9/10. Summary: The crosspoint limit, GraphSpace create defaults, compute-limit update semantics, PD-first deletion guidance and LOADING ownership text match CustomizedCrosspointsTraverser, GraphSpaceAPI, GraphManager.dropGraphSpace, PD ConfigService and GraphsAPI on master, and both earlier wording comments are fixed in both languages.
imbajin
left a comment
There was a problem hiding this comment.
Score: 7.0/10 · Confidence: high
Blocking: yes
Summary
The new GraphSpace create and update instructions omit a version boundary: following them against Server 1.7.0 can fail creation or silently retain a compute quota.
Evidence
Server 1.7.0 GraphSpaceAPI initializes the omitted create limits to zero and checks them greater than zero; its update handler ignores zero compute limits. Current master handles these cases differently.
Validation notes
Compared source code and the 1.7.0 tag; did not run a Server/PD deployment. The existing Kubernetes namespace omission is pre-existing and outside the changed lines.
…ritance differences
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The 1.8.0 and 1.7.0 create defaults, compute-limit update rules, PD-first deletion text and crosspoint limit match GraphSpaceAPI, GraphManager.dropGraphSpace, PD ConfigService and CustomizedCrosspointsTraverser, and both version comments are fixed in both languages. One unversioned client warning remains.
| > - **High-Precision Storage Metric**: In addition to the integer GB `storage_used` field, responses provide `storage_used_kb` for precise sub-GB | ||
| > tracking. `storage_percent` is calculated from this exact KB value. | ||
|
|
||
| Use a client that preserves omitted compute fields. Older clients can serialize an unset field as zero, unintentionally restoring inheritance. |
There was a problem hiding this comment.
Minor: "Older clients" names no version, so readers cannot tell whether their client resets compute limits; hugegraph-client 1.7.0 declares compute_cpu_limit and compute_memory_limit as int and always sends 0. Name the release, for example "hugegraph-client 1.7.0 and earlier serialize an unset compute field as 0, restoring inheritance.", and make the same change to "旧客户端" in content/cn/docs/clients/restful-api/graphspace.md.
Purpose of the PR
Correct the bilingual REST reference where outdated semantics can change how clients limit results, update quotas or delete graph spaces.
Validation: source-contract review, bilingual/anchor checks, strict build and independent artifact validation passed. Desktop/mobile checks covered the reference tables and deletion guidance. Public routes and existing heading links are preserved.
Pending standalone-storage and GraphID changes remain in their existing PRs.