Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The saved-connection precedence, path selection, key retention, role inheritance, test and use-chat routes, client_config handling and Thin API write gate match hugegraph-llm on apache/hugegraph-ai main, as do the extras, Compose image and ML/Vermeer packaging. One status-code statement is incomplete, in both languages.
…button label, drop local temp path
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The AI guides' saved-connection precedence, file paths, role inheritance, key retention, configuration and Thin API status codes, extras, Compose image and ML/Vermeer packaging match hugegraph-ai main, and the 422/400 split raised on the earlier head is fixed in both languages. One comment covers Helm text stacked from #574 that lacks its follow-up fixes.
imbajin
left a comment
There was a problem hiding this comment.
Score: 7.5/10 · Confidence: high
Blocking: yes
Summary
The existing Helm review comment remains applicable: the documented default shard replication condition can mislead operators when initial Store count and bootstrap Store replicas differ. No additional issue was verified.
Evidence
Compared the selected English and Chinese guide with current Server Helm _helpers.tpl and the existing inline discussion; inspected AI configuration and API changes against source.
Validation notes
Source-based review; no live Helm deployment, model connection or end-to-end application test was run.
…ing OnRootMismatch
f16bd21 to
49acb6b
Compare
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The AI guides are unchanged since the last reviewed head and still match hugegraph-ai main, and the rebase onto #574 resolves the earlier Helm comment, including the bootstrap.storeReplicas shard rule. One link in the stacked Chinese Helm text points to a missing anchor.
imbajin
left a comment
There was a problem hiding this comment.
Score: 8.0/10 · Confidence: high
Blocking: no
Summary
The existing Chinese Store rollout link issue remains: the link lands at the operations page top instead of the controlled rollout procedure. No additional issue was verified.
Evidence
Compared the selected guide's fragment with the explicit ID in the target heading and reviewed the existing inline discussion. The earlier bootstrap replica-count issue is corrected on this head.
Validation notes
Source-based review; no rendered-site browser check, live Helm deployment, model connection or end-to-end application test was run.
49acb6b to
4b51ad8
Compare
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The saved-connection paths and precedence, key retention, role inheritance, configuration and Thin API routes and status codes, Compose image, extras and ML/Vermeer/client packaging match hugegraph-ai main, and the three earlier comments are fixed. Two Minor items remain: the minimal OpenAI example detaches extraction and Text2Gremlin from Chat, and the image build step needs Python 3.12+ as python3.
|
|
||
| ```properties | ||
| LANGUAGE=EN | ||
| CHAT_LLM_TYPE=openai |
There was a problem hiding this comment.
Minor: OPENAI_EXTRACT_LANGUAGE_MODEL and OPENAI_TEXT2GQL_LANGUAGE_MODEL further down this block are role-specific fields, so LLMConfig._canonical sets extract_use_chat and text2gql_use_chat to False and this example detaches both roles from Chat, contrary to the inheritance this page describes. Drop those two lines here and in content/cn/docs/quickstart/hugegraph-ai/config-reference.md, or state that setting them makes the roles independent.
| touch hugegraph-llm/.env | ||
| # Set GRAPH_URL=server:8080 and matching GRAPH_USER / GRAPH_PWD in hugegraph-llm/.env | ||
| # Set GRAPH_URL=http://server:8080 and matching GRAPH_USER / GRAPH_PWD in hugegraph-llm/.env | ||
| ./scripts/build_llm_image.sh |
There was a problem hiding this comment.
Minor: build_llm_image.sh runs scripts/version.py with python3, and that script imports tomllib, so this step fails with ModuleNotFoundError wherever python3 is earlier than 3.11, such as the macOS system Python 3.9. State the Python requirement and the PYTHON_FOR_RELEASE override here and in content/cn/docs/quickstart/hugegraph-ai/hugegraph-llm.md.
| ./scripts/build_llm_image.sh | |
| # build_llm_image.sh needs Python 3.12+ as python3; otherwise set PYTHON_FOR_RELEASE to a Python 3.12+ interpreter | |
| ./scripts/build_llm_image.sh |
Purpose of the PR
Update the bilingual AI guides so deployment, saved configuration, API calls and Python installation agree with current source and available packages.
Validation: source/image contract review, JSON/curl checks, dependency-resolution dry runs and strict artifact checks passed. Desktop/mobile checks covered the task entry, configuration tables and native reader controls. All eight configuration-table screenshot states passed with the current OpenAI role table. No live model, GPU or ML training acceptance is claimed.
Based on Helm #68, which provides the unified RAG deployment section. Existing links and bilingual heading compatibility are preserved.
Summary by CodeRabbit