Repository navigation
Conversation
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The query-limit, Text2GQL, session, Clone Schema, quota, Vermeer and metadata claims match hugegraph-toolchain and hugegraph master, and all images, fixture digests and anchors resolve. Three added sentences anchor behaviour to a point in time or omit a version requirement, and the audit note points at an uncommitted artifact.
…nt inheritance contracts
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The query-limit, Text2GQL, session, Clone Schema, quota, Vermeer and H2 metadata claims match hugegraph-toolchain and hugegraph master, the four comments from the earlier head are fixed, and all images, digests and anchors resolve. Two added passages name UI labels that Hubble does not show.
imbajin
left a comment
There was a problem hiding this comment.
Score: 6.5/10 · Confidence: high
Blocking: yes
Summary
The new browser test leaves the PR artifact, and the linked Vermeer guide understates the supported algorithm catalog. Existing UI label corrections also remain applicable.
Evidence
Reviewed the test origin and canonical URL configuration, guide text, Hubble adapter allowlist and frontend translations.
Validation notes
Source inspection only; browser tests and a live Hubble/Vermeer deployment were not run.
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The query-limit, H2 metadata, Text2GQL, session, quota, Clone Schema and UI label claims match hugegraph-toolchain and hugegraph master, and the eight earlier comments are fixed at this head. The expanded Vermeer catalog names fast_louvain, which Hubble rejects, instead of louvain_weighted.
imbajin
left a comment
There was a problem hiding this comment.
Score: 7.0/10 · Confidence: high
Blocking: yes
Summary
The catalog names an unsupported algorithm and omits a supported one; the linked filter restrictions and diagnostics label also need correction. No additional actionable findings were identified.
Evidence
Compared the bilingual diff with DirectVermeerService's allowlist and filter validation and with frontend translations.
Validation notes
Source review only; browser tests and live Hubble/Vermeer workflows were not independently run.
…rty-filter restrictions and update PD diagnostics label
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: yes. Summary: The louvain_weighted name, property-filter restrictions and Configured PD endpoint sample label match hugegraph-toolchain master, and the earlier comments are fixed at this head. The <algorithm>.* parameter rule omits the cycle.*, filter.* and louvain.* keys of two newly listed algorithms, and one pointer names content the Vermeer guide lacks.
| Current Hubble accepts `pagerank`, `wcc`, `lpa`, `degree`, `closeness_centrality`, `betweenness_centrality`, `triangle_count`, `kcore`, and `sssp`. | ||
| The Hubble direct adapter accepts 19 algorithms: `pagerank`, `ppr`, `wcc`, `scc`, `lpa`, `slpa`, `degree`, `closeness_centrality`, `betweenness_centrality`, `triangle_count`, `kcore`, `sssp`, `clustering_coefficient`, `depth`, `cycle_detection`, `louvain`, `louvain_weighted`, `kout`, and `jaccard`. | ||
| Use the selected algorithm's form for its own parameters; PageRank keys do not apply to another algorithm. | ||
| The direct adapter accepts `compute.*`, the selected algorithm's `<algorithm>.*` keys and `output.need_statistics`. |
There was a problem hiding this comment.
Important: cycle_detection takes cycle.* and filter.* keys and louvain_weighted takes louvain.*, so a caller following the <algorithm>.* rule sends keys such as louvain_weighted.resolution that Hubble accepts and Vermeer ignores, running with defaults. Name these two exceptions here and at line 465 of the CN guide.
| {.steps} | ||
|
|
||
| See the [Vermeer guide](/docs/quickstart/computing/hugegraph-vermeer/#24-submit-and-integrate-via-hubble) for the supported algorithms, | ||
| parameters, API task IDs and result-cache limits. An existing Computer deployment remains accessible through its separate compatibility section. |
There was a problem hiding this comment.
Minor: section 2.4 of the Vermeer guide says nothing about result-cache limits, so this pointer leads nowhere, here and at CN line 259. Drop "result-cache limits" in both files, or add those limits to section 2.4 in both languages.
Purpose of the PR
Bring the English and Chinese Hubble guides and screenshots into line with the current application, so users can deploy, import, query and recover from common failures without relying on old UI behavior.
Validation: source checks, strict build, independent artifact/link checks and desktop/mobile interaction checks passed. Real standalone import/count and authenticated minimal Helm workflows are recorded in the screenshot fixtures. Original-image viewing, keyboard focus and mobile layout were checked.
The theme is already OINK 1.5.1; this PR changes content and reuses its public components.