Repository navigation
Conversation
Compare downloaded archives with the RC commit before signing.
zhjwpku
reviewed
Nov 6, 2026
| echo "Failed to decompress ${tar_gz}. Not signing." | ||
| exit 1 | ||
| fi | ||
| if ! git archive "${rc_hash}" --format=tar --prefix "${id}/" > "${verify_dir}/expected.tar"; then |
Collaborator
There was a problem hiding this comment.
One issue: git archive output depends on local config. I confirmed that core.autocrlf=true or tar.umask=022 produces a different tar, so a release manager with either setting would get a false "does not match RC commit" with no easy way around it. Could we pin the defaults CI uses?
git -c core.autocrlf=false -c core.eol=lf -c tar.umask=0002 \
archive "${rc_hash}" --format=tar --prefix "${id}/"
| import unittest | ||
|
|
||
|
|
||
| MOCK_TOOL = r''' |
Collaborator
There was a problem hiding this comment.
Do we need this test? Should we hook it into CI if yes?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary