Skip to content

Track and clean schema deletion mod-file progress - #19343

Draft
Caideyipi wants to merge 2 commits into
apache:masterfrom
Caideyipi:codex/async-schema-mod-file-progress
Draft

Caideyipi wants to merge 2 commits into
apache:masterfrom
Caideyipi:codex/async-schema-mod-file-progress

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Count deleted schema data by distinct mod file and report per-region progress.
  • Keep terminal cleanup targets pending until DataRegions confirm cleanup, so a failed or missing refresh RPC can be retried instead of leaving stale records.
  • Apply the same cleanup lifecycle to time-series, table, and column deletion; preserve an unknown remaining count until file discovery is complete.

Example

After DELETE TIMESERIES root.sg.d1.s1;, SHOW DELETE TIMESERIES PROGRESS; reports the operation while deletion is in progress. If a terminal cleanup RPC is unavailable, the progress entry remains pending for retry. It is removed only after cleanup reaches all target regions.

@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Independent review: complete; no actionable findings were reported for the reviewed patch, and no additional fixes were required in that round.

The patch retains target-region cleanup until the progress-clear RPC succeeds, so a missing or failed terminal refresh remains retryable instead of discarding DataRegion progress records.

  • Reviewed patch SHA: 1de7e24cd55c0aab4a25617a09ccbcc128b92a0f
  • Final local SHA: 564caed8603f4086151ab41172544ee0f93944ac
  • Confirmed remote head SHA: 564caed8603f4086151ab41172544ee0f93944ac
  • ConfigNode targeted suite: 53 tests passed.
  • DataNode targeted suite: 15 tests passed.
  • IoTDBDeleteTimeSeriesIT.testAsynchronousDeletionProgress: 2 SimpleIT tests and 2 ClusterIT tests passed.
  • Spotless exited 0; git diff --check passed.

Remote CI: pending.

@Caideyipi
Caideyipi marked this pull request as draft November 20, 2026 11:47
@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Summary

The C and C++ Session integration tests now wait for asynchronous timeseries deletion to finish before continuing. The updates also correct C API error handling and pooled-session calls for Windows/MSVC builds.

Verification

  • mvn verify -P with-cpp -pl iotdb-client/client-cpp -am -Dcmake.generator=Visual Studio 17 2022 -T1 succeeded. CTest passed 5 plain, 1 TLS, and 1 mutual-TLS test against a locally built master-based server. The C++ test source files are byte-identical to the files in this commit.
  • git diff --check passed.
  • A clean distribution build from this PR's server source did not complete: the first attempt hit a local JAR-scanning exception, and the bounded retry was stopped when available memory became critically low during another local build. The C++ suite has not been run against a server built from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant