Repository navigation
Conversation
Collaborator
Author
|
Independent review: complete; no actionable findings were reported for the reviewed patch, and no additional fixes were required in that round. The patch retains target-region cleanup until the progress-clear RPC succeeds, so a missing or failed terminal refresh remains retryable instead of discarding DataRegion progress records.
Remote CI: pending. |
Caideyipi
marked this pull request as draft
November 20, 2026 11:47
Collaborator
Author
SummaryThe C and C++ Session integration tests now wait for asynchronous timeseries deletion to finish before continuing. The updates also correct C API error handling and pooled-session calls for Windows/MSVC builds. Verification
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example
After
DELETE TIMESERIES root.sg.d1.s1;,SHOW DELETE TIMESERIES PROGRESS;reports the operation while deletion is in progress. If a terminal cleanup RPC is unavailable, the progress entry remains pending for retry. It is removed only after cleanup reaches all target regions.