Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.apache.iotdb.db.queryengine.plan.statement.crud.LoadTsFileStatement;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;
import org.apache.iotdb.db.storageengine.load.config.LoadTsFileConfigurator;
import org.apache.iotdb.db.utils.MemUtils;

import org.apache.tsfile.utils.RamUsageEstimator;

Expand All @@ -49,9 +50,6 @@
private static final long INSTANCE_SIZE =
RamUsageEstimator.shallowSizeOfInstance(LoadTsFile.class);

private static final long FILE_INSTANCE_SIZE =
RamUsageEstimator.shallowSizeOfInstance(File.class);

private String filePath;

private int databaseLevel; // For loading to tree-model only
Expand Down Expand Up @@ -383,20 +381,12 @@
}

@Override
public long ramBytesUsed() {

Check failure on line 384 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaH4gb2Sxy5OXFn1BRZj&open=AaH4gb2Sxy5OXFn1BRZj&pullRequest=19347
long size = INSTANCE_SIZE;
size += AstMemoryEstimationHelper.getEstimatedSizeOfNodeLocation(getLocationInternal());
size += RamUsageEstimator.sizeOf(filePath);
size += RamUsageEstimator.sizeOf(database);
size += RamUsageEstimator.sizeOfMap(loadAttributes);
if (tsFiles != null) {
size += RamUsageEstimator.shallowSizeOf(tsFiles);
for (File file : tsFiles) {
if (file != null) {
size += FILE_INSTANCE_SIZE;
}
}
}
if (resources != null) {
size += RamUsageEstimator.shallowSizeOf(resources);
for (TsFileResource resource : resources) {
Expand All @@ -405,6 +395,18 @@
}
}
}
if (tsFiles != null) {
size += RamUsageEstimator.shallowSizeOf(tsFiles);
for (int i = 0; i < tsFiles.size(); i++) {
File file = tsFiles.get(i);
// Analysis appends one resource (possibly null) for each processed file, in order.
TsFileResource resource =
resources != null && i < resources.size() ? resources.get(i) : null;
if (resource == null || resource.getTsFile() != file) {
size += MemUtils.getFileRamBytes(file);
}
}
}
size += AstMemoryEstimationHelper.getEstimatedSizeOfLongList(writePointCountList);
size += RamUsageEstimator.shallowSizeOf(isTableModel);
return size;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,13 @@ public boolean isInsertionSelectionDelayed(long timePartitionId) {

public void addResourceDeviceTimeIndex(
TsFileResource tsFileResource, ArrayDeviceTimeIndex deviceTimeIndex) {
partitionFileDeviceInfoCache.put(tsFileResource, deviceTimeIndex);
ArrayDeviceTimeIndex previous =
partitionFileDeviceInfoCache.put(tsFileResource, deviceTimeIndex);
if (previous == deviceTimeIndex) {
return;
}
long deviceTimeIndexSize =
tsFileResource.getDeviceTimeIndexRamSize().orElse(deviceTimeIndex.calculateRamSize());
deviceTimeIndex.calculateRamSize() - (previous == null ? 0 : previous.calculateRamSize());
cachedDeviceInfoSize += deviceTimeIndexSize;
CompactionMetrics.getInstance().addSelectionCachedDeviceTimeIndexSize(deviceTimeIndexSize);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
import org.apache.iotdb.db.storageengine.dataregion.modification.v1.Modification;
import org.apache.iotdb.db.storageengine.dataregion.modification.v1.ModificationFileV1;
import org.apache.iotdb.db.storageengine.dataregion.tsfile.TsFileResource;
import org.apache.iotdb.db.utils.MemUtils;

import org.apache.tsfile.utils.Accountable;
import org.apache.tsfile.utils.RamUsageEstimator;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -51,6 +54,7 @@
import java.util.Map.Entry;
import java.util.NoSuchElementException;
import java.util.Set;
import java.util.concurrent.locks.AbstractQueuedSynchronizer;
import java.util.concurrent.locks.ReentrantReadWriteLock;
import java.util.stream.Collectors;

Expand All @@ -59,7 +63,14 @@
import static org.apache.iotdb.db.utils.ModificationUtils.sortAndMerge;
import static org.apache.tsfile.common.constant.TsFileConstant.TSFILE_SUFFIX;

public class ModificationFile implements AutoCloseable {
public class ModificationFile implements AutoCloseable, Accountable {

private static final long INSTANCE_SIZE =
RamUsageEstimator.shallowSizeOfInstance(ModificationFile.class)
+ RamUsageEstimator.shallowSizeOfInstance(ReentrantReadWriteLock.class)
+ RamUsageEstimator.shallowSizeOfInstance(ReentrantReadWriteLock.ReadLock.class)
+ RamUsageEstimator.shallowSizeOfInstance(ReentrantReadWriteLock.WriteLock.class)
+ RamUsageEstimator.shallowSizeOfInstance(AbstractQueuedSynchronizer.class);

public static final String FILE_SUFFIX = ".mods2";
public static final String COMPACTION_FILE_SUFFIX = ".compaction.mods2";
Expand Down Expand Up @@ -92,6 +103,12 @@ public ModificationFile(File file, boolean updateModMetrics) {
}
}

/** Long-lived handle and lock. Open streams and cascaded files have separate lifetimes. */
@Override
public long ramBytesUsed() {
return INSTANCE_SIZE + MemUtils.getFileRamBytes(file);
}

public void writeLock() {
this.lock.writeLock().lock();
}
Expand Down
Loading
Loading