Skip to content

Stabilize IoTConsensus peer recovery notifications - #19348

Open
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/iot-consensus-peer-recovery-notification
Open

Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/iot-consensus-peer-recovery-notification

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

During peer recovery, rebuilding a peer can overlap server startup and dispatcher progress-index updates, leaving recovery notifications stale. This change coordinates peer reconstruction, startup, and watermark/index publication, and cleans up partially initialized server state when startup fails so a retry can rebuild consistently. Recovery regression tests cover the rebuilt-peer path.

Validation

  • New unit tests: 12/12 passed.
  • Spotless passed.
  • IoTDBConsensusSubscriptionRecoveryTableIT.testRebuiltConsumersResumeAfterFullClusterRestart failed after restart: the test observed only the initial 16 rows and not the 64 rows written before restart. The cause and relationship to this change are unconfirmed.

@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Review summary

  • Reviewed base: df29e881cab29769b8b52498bce862a0f9e5a6d2. No confirmed actionable findings; no production or test-logic fixes were needed.
  • Final local commit and confirmed remote head: 351a7a500fb303e61b4bb08bfbee46b8fbfc00a0. The published four-file patch matches the reviewed patch exactly.
  • Validation: newly added unit tests passed (12/12); Spotless passed. IoTDBConsensusSubscriptionRecoveryTableIT.testRebuiltConsumersResumeAfterFullClusterRestart failed after restart, observing only the initial 16 rows and not the 64 rows written before restart. Its cause and relationship to this change remain unconfirmed.
  • Incomplete update steps: none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant