Repository navigation
fix(lucene): isolate lock factories for concurrent directory creation - #501
Merged
Merged
Conversation
SteNicholas
reviewed
Nov 3, 2026
Member
There was a problem hiding this comment.
@lszskye, I left two comments on writer-side regression coverage and documenting why lock factories must be isolated. PTAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #500
Allocate a separate NoLockFactory for each reader and writer directory.
The singleton factory shares a mutable lockPrefix that Directory::
setLockFactory updates without synchronization, causing a data race
and potential double-free during concurrent directory creation.
Add a multithreaded regression test verifying that each directory
retains its own distinct lock prefix.
Tests
src/paimon/global_index/lucene/lucene_directory_test.cpp
Generative AI tooling
Generated-by: OpenAI Codex