Repository navigation
GH-3695: Consolidate benchmark JAR license notices - #3815
Open
efegokdemir wants to merge 3 commits into
Open
efegokdemir wants to merge 3 commits into
efegokdemir wants to merge 3 commits into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
Let notice transformers read resources before shading and append canonical license resources without discarding project or dependency text. Validated both extracted module configurations with Shade 3.6.2: the existing JAR-content check fails before and passes after, including project and dependency resources. Selected reactor validate also passes. Assisted-By: OpenAI Codex
Append LICENSE.txt and LICENSE.md resources in both benchmark JARs and use UTF-8 when merging NOTICE attributions. Generated-by: dot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The two benchmark uber-JARs currently copy every dependency's
META-INF/LICENSE*andMETA-INF/NOTICE*resource into the shaded artifact. This produces multiple license and notice files and makes the local benchmark artifacts fail the repository's expected packaging check.What changes are included in this PR?
Fixes #3695
Are these changes tested?
git diff --check.Are there any user-facing changes?
No runtime code changes. The generated benchmark JARs now contain consolidated
META-INF/LICENSEandMETA-INF/NOTICEresources.AI assistance was used for repository navigation and drafting this focused change. I reviewed the complete diff and take responsibility for the submitted patch.