Repository navigation
MINOR: [1.18.x] Revert "Set version to 1.18.2 for release" - #3931
Merged
Fokko merged 1 commit intoNov 3, 2026
Merged
Conversation
This reverts commit 490699b. Besides bumping the POMs to 1.18.2, that commit picked up the thrift-0.25.0/ directory the prepare-RC workflow had built in the checkout (prepare-rc.sh staged with `git add -A`). That put 3,550 Thrift files, compiled .o files included, into 1.18.2-rc0. Reverting puts the branch back to 9ea3b78 (1.18.2-SNAPSHOT), so the next prepare-RC run makes a fresh version-bump commit. The workflow side is fixed on master in apache#3929, which must be merged before that run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RussellSpitzer
approved these changes
Nov 3, 2026
RussellSpitzer
left a comment
RussellSpitzer
left a comment
Member
There was a problem hiding this comment.
Good call here, Sorry about that working tree issue
Fokko
approved these changes
Nov 3, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Whoops, how did Thrift get in there :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The release commit 490699b ("Set version to 1.18.2 for release"), which is the current head of
parquet-1.18.x, did more than bump the 18 POM versions. It also committedthrift-0.25.0/: 3,550 files (about 332 MB unpacked), including 40 compiled x86-64.ofiles and the files Thrift'sconfiguregenerates. The prepare-RC workflow had built Thrift inside the checkout, andprepare-rc.shstaged the version bump withgit add -A. The tree ended up in the 1.18.2-rc0 source tarball (72.6 MB, against 1.4 MB for 1.18.1), so RC0 cannot be released.What changes are included in this PR?
git revert 490699b8. The branch tree becomes identical to 9ea3b78 (git diff 9ea3b783 HEADis empty), with the POMs back at1.18.2-SNAPSHOT.Are these changes tested?
git diff 9ea3b783 HEADis empty, so the tree matches the commit before the release bump, which already passed CI.Are there any user-facing changes?
No.
🤖 Generated with Claude Code