Repository navigation
MINOR: Set the POM SCM tag when preparing and publishing releases - #3933
Merged
Merged
Conversation
prepare-rc.sh only ran versions:set, so <scm><tag> in the root POM kept whatever the release branch carried. The 1.18.2 RCs shipped apache-parquet-1.18.0-rc2 and the 1.19.0 RCs shipped HEAD. - prepare-rc.sh writes the RC tag into <scm><tag> in the release commit, including on rc1+ when the version is already set, and refuses to tag and deploy if the committed tag doesn't match. - publish-release.sh checks out the release branch before comparing it with the RC tag (the workflow is dispatched from master), and resets <scm><tag> to HEAD in the next development iteration commit.
wgtmac
approved these changes
Nov 5, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks @RussellSpitzer for fixing this! I also noticed that we cannot run publish-release successfully for 1.18.x without this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
prepare-rc.sh only ran versions:set, so in the root POM kept whatever the release branch carried. The 1.18.2 RCs shipped apache-parquet-1.18.0-rc2 and the 1.19.0 RCs shipped HEAD.
What changes are included in this PR?
Are these changes tested?
Locally checked that we are correctly checking and creating poms correctly
Are there any user-facing changes?
No