Repository navigation
Fix Southern Hemisphere DST detection in browser info - #1975
Merged
bitstorm merged 1 commit intoNov 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1975 +/- ##
============================================
+ Coverage 62.83% 62.87% +0.03%
- Complexity 11569 11574 +5
============================================
Files 1255 1255
Lines 48759 48759
Branches 6877 6877
============================================
+ Hits 30640 30655 +15
+ Misses 15427 15414 -13
+ Partials 2692 2690 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1949
This pull request corrects daylight-saving time (DST) offset detection in Apache Wicket's browser information collection.
Previously,
wicket-browser-info.jsassumed that January 1 always represented standard time and July 1 always represented daylight-saving time. That assumption fails in Southern Hemisphere timezones, where summer occurs around January.Changes
utcOffset) and the larger offset for daylight-saving time (utcDSTOffset), independent of hemisphere.Regression test coverage
Australia/SydneyAmerica/New_YorkAsia/ColomboAustralia/Lord_HoweValidation
npx grunt jshint:core jshint:testsJs— passed (6 production files and 11 test files lint-free).npx grunt connect qunit— passed:Scope
Only browser timezone detection and its JavaScript regression test coverage are changed. No dependency upgrades are included.