Repository navigation
Conversation
Watch currently excludes relationships that were removed because they expired, so a Watch consumer cannot tell that access ended. Datastores that record expirations as changes can now report them. - RelationshipUpdate.Operation gets OPERATION_EXPIRE = 4. - WatchKind gets WATCH_KIND_INCLUDE_RELATIONSHIP_EXPIRATIONS = 4. Watch reports OPERATION_EXPIRE only when the request asks for it, so existing clients never receive an enum value they do not know. - WriteRelationshipsRequest rejects OPERATION_EXPIRE with a protovalidate CEL rule. protoc-gen-validate cannot express this check, so servers that use it must reject the operation themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watch currently excludes relationships that were removed because they expired, so a Watch consumer cannot tell that access ended. This adds a way for a server to report those removals.
Changes
RelationshipUpdate.OperationgetsOPERATION_EXPIRE = 4.WatchKindgetsWATCH_KIND_INCLUDE_RELATIONSHIP_EXPIRATIONS = 4. Watch reportsOPERATION_EXPIREonly when the request includes this kind, so existing clients never receive an enum value they do not know. Servers that do not record expirations as changes return no such updates.WriteRelationshipsRequestrejectsOPERATION_EXPIREwith a protovalidate CEL rule.RelationshipUpdateis shared by writes and Watch, so the rule is on the request, not on the field. protoc-gen-validate cannot express this check, so servers that use it must reject the operation themselves.docs/apidocs.swagger.jsonis regenerated.An
OPERATION_EXPIREupdate is reported at the revision where the server removed the relationship, which is at or after itsoptional_expires_at.Checks
buf build,buf lint, andbuf breaking --against upstream/mainpass.