Repository navigation
Reject recipient addresses from the wrong network - #370
Open
emma31-dev wants to merge 2 commits into
Open
emma31-dev wants to merge 2 commits into
emma31-dev wants to merge 2 commits into
Conversation
5 tasks done
Validate network on --to addresses and --to-sp silent payment codes in create_tx, create_sp_tx, and create_dns_tx. Previously these commands would silently build an unspendable PSBT; they now return a clear error with the expected and actual network. - parse_recipient now stores Address<NetworkUnchecked> instead of ScriptBuf - New recipient_script() helper validates network before converting to ScriptBuf - Silent payment codes also validated against wallet network - Tests added for all three commands with wrong-network inputs
emma31-dev
force-pushed
the
fix/360-create-tx-network-validation
branch
from
November 9, 2026 21:53
9c0cef4 to
eecb1d4
Compare
emma31-dev
marked this pull request as draft
November 13, 2026 12:23
emma31-dev
marked this pull request as ready for review
November 13, 2026 15:04
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 60.00% 59.76% -0.25%
==========================================
Files 25 25
Lines 4736 4608 -128
==========================================
- Hits 2842 2754 -88
+ Misses 1894 1854 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #360 .
Retain recipient addresses as unchecked addresses until the wallet network is available, then validate them before converting them to scripts.
create_tx,create_sp_tx --to, andcreate_dns_tx --tonow reject addresses from a different network.create_sp_tx --to-spalso rejects silent payment codes whose network differs from the wallet’s.Notes to the reviewers
The mismatch errors use
BDKCliError::Genericwith a formatted message rather than adding payload-carrying error variants. Carrying an address or silent payment code in new variants madeBDKCliErrorlarge enough for Clippy’sresult_large_errlint to fail across many functions.Some integration tests used testnet
tb1...recipients with regtest wallets. Those fixtures now use regtest addresses so the tests exercise their intended behavior instead of failing at network validation.Checklists
All Submissions:
cargo fmtcargo clippysuccessfully before committingBugfixes: