Repository navigation
Conversation
Also raise the @bytecodealliance/weval floor to ^0.5.1 to match the weval version StarlingMonkey's cmake/weval.cmake now fetches.
Exercises crypto.subtle.importKey/deriveBits (PBKDF2-SHA256) and importKey/encrypt/decrypt (AES-256-CBC) landed in StarlingMonkey v0.5.0, asserting against known-answer vectors.
draco2003
requested review from
andreiltd,
tschneidereit and
vados-cosmonic
as code owners
November 9, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
StarlingMonkeysubmodule from9dda8ba(starlingmonkey-v0.3.0) tocce4d3d(starlingmonkey-v0.5.0).What's new in StarlingMonkey v0.3.0 → v0.5.0
v0.5.0
crypto.subtle: PBKDF2importKey+deriveBits(StarlingMonkey#346)crypto.subtle: AES-CBCimportKey+encrypt/decrypt(StarlingMonkey#360)CryptoKeyclass is now finalizable (StarlingMonkey#362)key_ops(StarlingMonkey#363)Request/Responsetext()/json()(StarlingMonkey#348)v0.4.0
crypto.subtle: Ed25519 support (StarlingMonkey#330), additional key usages (StarlingMonkey#334)Response.clone()(StarlingMonkey#312)#337)FinalizationRegistrycleanup callbacks now run (StarlingMonkey#331)#324)Changes in this PR
StarlingMonkeysubmodule →starlingmonkey-v0.5.0.package.json: raise the@bytecodealliance/wevalfloor^0.5.0→^0.5.1(lockfile updated) so it matches the weval version StarlingMonkey'scmake/weval.cmakenow fetches.New bindings test case
test/cases/crypto-subtle/(auto-discovered bytest/bindings.js). The component exports async functions that:importKey('raw', …, 'PBKDF2')+deriveBitswith PBKDF2-SHA256 (1000 iterations, 256 bits),importKey('raw', …, 'AES-CBC')+encrypt/decryptwith AES-256-CBC,and
test.jsasserts the hex output against known-answer vectors computed with Node'scrypto.pbkdf2Sync/crypto.createCipheriv(cross-checked with Pythonhashlibandopenssl enc), plus a decrypt round-trip.No changes to the embedding were needed.
Verification (Linux x86_64)
npm install,make release(buildslib/starlingmonkey_embedding.wasmfrom the new submodule with wasi-sdk 30): OKnpm test: 7 files passed, 80 passed / 1 skipped (81). The skip is the existing Windows-onlySplicer filesystem > reads namespaced Windows paths.crypto-subtlepasses.npm run build:weval: OKnpm run test:weval(WEVAL_TEST=1): 7 files passed, 80 passed / 1 skipped (81),crypto-subtleincluded.make debug/npm run test:debug) was not run.