Repository navigation
Made deploy show policy errors reported by cf-promises - #207
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 49.54% 49.64% +0.09%
==========================================
Files 18 18
Lines 3217 3217
==========================================
+ Hits 1594 1597 +3
+ Misses 1623 1620 -3
🚀 New features to boost your workflow:
|
larsewi
requested changes
Nov 5, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Showed cf-promises errors from remote hosts
Commit message does not read well
cf-agent runs cf-promises to validate the policy, and cf-promises writes errors like a duplicate bundle to stderr. Since only stdout was captured, these errors were silently dropped. Redirected stderr to stdout and extended the error pattern to also match the "file.cf:12:0: error:" format used by cf-promises. Signed-off-by: Victor Moene <victor.moene@northern.tech> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
victormlg
force-pushed
the
deploy-show-stderr-errors
branch
from
November 5, 2026 15:39
afc5eed to
c4e3545
Compare
larsewi
changed the title
larsewi
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.