Repository navigation
cf-reactor: fix watchers on windows - #6471
Merged
larsewi merged 2 commits intoNov 5, 2026
Merged
Conversation
victormlg
changed the title
victormlg
marked this pull request as ready for review
November 4, 2026 13:38
larsewi
requested changes
Nov 4, 2026
st_uid/st_gid are always 0 on Windows, so the owner SID is compared instead Signed-off-by: Victor Moene <victor.moene@northern.tech>
LogCheckError() passed errno values to GetErrorStrFromCode(), which on Windows expects a Windows error code, so the logged reason was wrong. Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor-windows-error-messages
branch
from
November 5, 2026 07:44
c8bb471 to
8820b4f
Compare
larsewi
approved these changes
Nov 5, 2026
Contributor
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/15006/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-15006/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge together: https://github.com/cfengine/enterprise/pull/1029