Skip to content

feat(ENG-15913): release a new major version of the action for a new CLI major version - #56

Draft
cloudsmith-iduffy wants to merge 3 commits into
masterfrom
eng-15913
Draft

cloudsmith-iduffy wants to merge 3 commits into
masterfrom
eng-15913

Conversation

@cloudsmith-iduffy

@cloudsmith-iduffy cloudsmith-iduffy commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

A new CLI major version now gets a new major version of the action. When CLI 2.0.0 ships, the action releases v4 with CLI 2.0.0, and @v3 stays on CLI 1.x. CLI 2.0.0 is a breaking release. Without this PR, its release would pin the @v3 default to 2.0.0 and put a breaking change inside v3.

Each CLI release sends a cloudsmith-cli-release event to this repository (cloudsmith-io/cloudsmith-cli#627). scripts/bump-cli-version.sh then moves the default and adds a CHANGELOG.md section. Today the section is always a patch or minor release. This PR makes it a major release when the CLI major version changes.

CLI 1.32.0 ships

bump-cli-version.sh 1.32.0 moves the default to 1.32.0 and adds a CHANGELOG.md section, as before. This PR adds an [Unreleased] entry, so that section is a minor release of the action, 3.3.0.

CLI 2.0.0 ships

  1. bump-cli-version.sh 2.0.0 finds a different major version from the pinned default. It pins 2.0.0, and adds a 4.0.0 section to CHANGELOG.md.
  2. Cloudsmith Bot opens the bump pull request, and merges it when the checks pass.
  3. The merge changes CHANGELOG.md on master, so release.yml runs. It creates the v4.0.0 release, and creates the floating v4 tag, because no v4 tag exists yet.
  4. @v3 stays on the last 3.x release, which pins CLI 1.x.

CLI 1.40.3 ships after 2.0.0

1.40.3 is older than the pinned 2.0.0, so the script changes nothing. @v3 gets no more CLI bumps.

An older CLI release ships

The script changes nothing, as before.

Other changes

  • A new test case pins 1.29.0, requests 2.0.0, and expects 4.0.0.
  • CONTRIBUTION.md describes the major release.
  • CHANGELOG.md has the [Unreleased] entry.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other

Additional Notes

ENG-15913.

Testing

  • The new test case fails against the old script and passes after the change.
  • bash scripts/test-bump-cli-version.sh passes.
  • bash -n and shellcheck --severity=style pass on both bump scripts.
  • On a copy of this repository:
    • bump-cli-version.sh 2.0.0 pins 2.0.0, and adds a 4.0.0 section that includes the new [Unreleased] entry.
    • bump-cli-version.sh 1.32.0 adds a 3.3.0 section that includes the new [Unreleased] entry.
    • After the 2.0.0 bump, bump-cli-version.sh 1.40.3 prints nothing and changes no files.

Still to do before this PR leaves draft

  • Release installer 0.2.0, which accepts cli-version: 1.
  • Copy installer 0.2.0 into installer/, and update the cli-version input description.

🤖 Generated with Claude Code

The CLI release dispatch sends every new Cloudsmith CLI version. A 2.0.0
release would pin the v3 default cli-version to a breaking CLI version.
The bump script now ignores a CLI version with a different major version.
It prints nothing and changes no files, as for a version that is already
pinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change intended to prevent automated CLI bumps across major versions.

No open issues 🎉

What changed in this PR

Prevents automated CLI bumps from introducing a breaking CLI major version into the action’s existing major release, keeping @v3 on Cloudsmith CLI 1.x.

Changes:

  • Skips versions whose major differs from the pinned default, exiting successfully without stdout or file changes.
  • Adds a regression test for a CLI 2.0.0 release.
  • Documents the guard and adds an unreleased changelog entry.
File Description
scripts/​test-bump-cli-version.sh Checks that CLI 2.0.0 produces no stdout or file changes.
scripts/​bump-cli-version.sh Adds the major-version guard and updates its header comment.
CONTRIBUTION.md Documents that cross-major CLI releases are ignored.
CHANGELOG.md Records the fix under [Unreleased].

Review effort: Balanced

cloudsmith-iduffy and others added 2 commits November 18, 2026 17:03
* origin/master:
  ci: use the standard cloudsmith-bot secret names (#57)
…CLI major version

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudsmith-iduffy cloudsmith-iduffy changed the title feat(ENG-15913): keep the default cli-version on one major version feat(ENG-15913): release a new major version of the action for a new CLI major version Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants