Skip to content

feat(ENG-15913): keep update and the update check in the running major version - #629

Draft
cloudsmith-iduffy wants to merge 11 commits into
masterfrom
eng-15913-update
Draft

cloudsmith-iduffy wants to merge 11 commits into
masterfrom
eng-15913-update

Conversation

@cloudsmith-iduffy

@cloudsmith-iduffy cloudsmith-iduffy commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR keeps cloudsmith update and the update check in the running major version. After 2.0.0 ships, a 1.x pipeline that runs cloudsmith update -y keeps getting 1.x releases, without the breaking changes in 2.0.0.

This PR builds on #627, which publishes an install manifest for each major version.

Update 1.40.2 after 2.0.0 and 1.40.3 ship

  • cloudsmith update reads cloudsmith-cli-manifest-<target> and finds 2.0.0. Because 2.0.0 is a new major version, it also reads cloudsmith-cli-v1-manifest-<target>, finds 1.40.3, and installs 1.40.3.
  • cloudsmith update then reports that 2.0.0 is available, and links to the v2.0.0 release notes. It never installs 2.0.0.
  • With -F json, the output includes "new_major_version": "2.0.0".
  • The update notice shows the same information.

Update 1.40.2 when 1.40.3 is the highest release

cloudsmith update reads cloudsmith-cli-manifest-<target>, finds 1.40.3, and installs it. It makes one request, as today.

Upgrade with a package manager

The update notice for 1.40.2 shows an upgrade command that stays on 1.x:

  • pip: pip install --upgrade "cloudsmith-cli<2"
  • pipx: pipx install --force --pip-args=--upgrade "cloudsmith-cli<2". pipx upgrade doesn't accept a version specifier.
  • uv: uv tool upgrade "cloudsmith-cli<2". This requires uv 0.5.5 or later. uv tool install with a specifier keeps the installed version and removes the extras.
  • Docker: docker pull cloudsmith/cloudsmith-cli:1
  • Homebrew: a cloudsmith-cli@1 formula follows in a separate change.

Install 1.40.2 and 2.0.0 on one machine

Each major version keeps its own update-check state. 1.40.2 uses update_check-v1.json, and 2.0.0 uses update_check-v2.json. Neither install overwrites the other.

Run the 1.40.2 Windows standalone binary

Today the update notice links to releases/latest, which points at v2.0.0 after 2.0.0 ships. The notice now refers to the release notes link in the line above, which points at v1.40.3.

Update a release from before this change

1.39.0 reads only cloudsmith-cli-manifest-<target>, so cloudsmith update on 1.39.0 installs 2.0.0. This change ships well before 2.0.0, so most installs will have it first.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (please describe)

Additional Notes

ENG-15913.

Testing: the tests for the update check, the installation, cloudsmith update, and the main command pass (164 tests).

🤖 Generated with Claude Code

cloudsmith-iduffy and others added 8 commits November 18, 2026 11:51
Each release also pushes its install manifest as
cloudsmith-cli-v<MAJOR>-manifest-<target>. The update check and
`cloudsmith update` stay in the running major version, and suggest a
higher major version without installing it. The upgrade commands for
pip, pipx, uv and Docker stay in the running major version.

The Docker Hub floating tags and the GitHub "Latest" release move only
for the highest release in their channel. A pre-release moves no
channel and sends no downstream event. The downstream event now also
goes to cloudsmith-ado-integration, orb and cloudsmith-sbx-kits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The promote-channels job moves the Docker Hub floating tags and the
GitHub "Latest" release after publish-github. All release tags share
its concurrency group, so an older release that finishes last cannot
move a channel back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release-channels concurrency group uses queue: max, so a new
release does not cancel a waiting promotion. The channel script reads
the published releases, so a tag whose release failed does not stop a
lower release from moving its channels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* origin/master:
  ci: use the standard cloudsmith-bot secret names (#628)
Replace release-channels.sh with release_channels.py. The script keeps
its inline metadata in the file header, and uv runs it. It gives the
same output as the shell script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release_channels.py reads the releases with requests, not the gh CLI.
The new promote_channels.py moves the GitHub "Latest" release and the
Docker Hub floating tags, so the workflow keeps no large shell block.
The script header gives examples of why a channel moves only for the
highest release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The update command changes move to the eng-15913-update branch, which
is stacked on this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r version

cloudsmith update and the update check read the install manifest of the
running major version. The upgrade commands for pip, pipx, uv and
Docker stay in that major version. When a new major version is
available, the update notice and cloudsmith update link to its release
notes, but cloudsmith update never installs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The generated uv tool upgrade command passes a requirement specifier where an installed tool name is expected, causing the update to fail.

1 open issue
What changed in this PR

Keeps CLI updates within the running major version while separately notifying users about newer major releases and their breaking changes.

Changes:

  • Adds major-specific manifest selection and update-check caches.
  • Adds new-major notices, release-note links, and a new_major_version JSON field.
  • Revises package-manager upgrade instructions, tests, and release documentation.
File Description
cloudsmith_cli/​core/​update_check.py Selects major-specific manifests, caches results, and displays new-major notices.
cloudsmith_cli/​core/​tests/​test_update_check.py Tests manifest selection, per-major caches, and notifications.
cloudsmith_cli/​core/​tests/​test_installation.py Checks major-aware upgrade command strings.
cloudsmith_cli/​core/​installation.py Adds major-version constraints to displayed upgrade instructions.
cloudsmith_cli/​cli/​tests/​commands/​test_update.py Tests new-major messaging, JSON output, and updated command behavior.
cloudsmith_cli/​cli/​tests/​commands/​test_main.py Updates background-notice expectations.
cloudsmith_cli/​cli/​commands/​update.py Uses major-aware manifests and reports newer majors separately.
CHANGELOG.md Documents major-preserving updates and new-major notifications.

Review effort: Balanced

CHANNEL_PIPX: (
'pipx install --force --pip-args=--upgrade "cloudsmith-cli<{next_major}"'
),
CHANNEL_UV_TOOL: 'uv tool upgrade "cloudsmith-cli<{next_major}"',
cloudsmith-iduffy and others added 2 commits November 19, 2026 13:32
The CLI has no release candidates, so the release workflow does not
need a pre-release path. A tag that is not MAJOR.MINOR.PATCH now fails
promote-channels. promote_channels.py now also holds the channel check,
because the validate job no longer runs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* eng-15913:
  ci(ENG-15913): remove the pre-release handling

# Conflicts:
#	CHANGELOG.md
Base automatically changed from eng-15913 to master November 19, 2026 15:16
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* origin/master:
  feat(ENG-15913): add a release channel for each major version (#627)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants