Skip to content
Navigation Menu
Sign in
Products
Platform
GitHub
Repository hosting, code review, and collaboration
Copilot
AI coding agent for tasks, projects and automated work
Build & Ship
Actions
CI/CD and automation
Code Quality
Quality analysis, fixes, and enforcement
Codespaces
Cloud development environments
Secure
Code Security
Vulnerability detection and remediation
Secret Protection
Secret scanning and leak prevention
All Features
Developers
Learn
Documentation
Training
Certifications
Build
Build with Copilot
Customize Copilot
Integrations
Explore
Trending repos
GitHub Sponsors
Developer articles
Changelog
Changelog
Your source for the latest features, improvements, and fixes across GitHub products, all in one place.
Businesses
By Stage
Enterprises
Team
Startups
Nonprofits
By Industry
Healthcare
Financial services
Manufacturing
Government
See all industries
Evaluate GitHub
Why GitHub
Customer Stories
Business insights
Trust Center
Add-ons
GitHub Advanced Security
Enterprise-grade code security
Copilot for business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Resources
Learn & Connect
Documentation
Resource center
Blog
Events & webinars
Community Forum
Customer Stories
Integrations
Support
Customer support
Training
GitHub Status
Company
About
Partners
Changelog
GitHub Universe
GitHub Universe
The event for developers, by developers — talks, workshops, and what’s next for GitHub.
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
coder
websocket
Repository navigation
Code
Issues
58
(58)
Pull requests
26
(26)
Actions
Security and quality
Insights
More
items
feat: add ErrorHandler to AcceptOptions
- #588
#588
Draft
mafredri
wants to merge 18 commits into
master
coder/websocket:master
from
mafredri/accept-error-handler
coder/websocket:mafredri/accept-error-handler
Copy head branch name to clipboard
Conversation
Commits
18
(18)
Checks
Files changed
Draft
feat: add ErrorHandler to AcceptOptions
#588
mafredri
wants to merge 18 commits into
master
coder/websocket:master
from
mafredri/accept-error-handler
coder/websocket:mafredri/accept-error-handler
Copy head branch name to clipboard
Commits
Commits on Nov 3, 2026
test(accept): pin Accept rejection responses
Show description for 7bd7405
mafredri
committed
7bd7405
View commit details
Copy full SHA for 7bd7405
Browse repository at this point
feat: add AcceptOptions.ErrorHandler
Show description for 0eca8fe
mafredri
committed
0eca8fe
View commit details
Copy full SHA for 0eca8fe
Browse repository at this point
refactor(accept.go): rename writeRejection body to defaultBody
Show description for 06b6aac
mafredri
committed
06b6aac
View commit details
Copy full SHA for 06b6aac
Browse repository at this point
docs(accept.go): state that ErrorHandler err is not for the client
Show description for 6427739
mafredri
committed
6427739
View commit details
Copy full SHA for 6427739
Browse repository at this point
test(accept_test.go): check ErrorHandler is not called on hijack failure
Show description for 5728d8e
mafredri
committed
5728d8e
View commit details
Copy full SHA for 5728d8e
Browse repository at this point
test(accept_test.go): send the server subtest request over a raw conn
Show description for 273a0ac
mafredri
committed
273a0ac
View commit details
Copy full SHA for 273a0ac
Browse repository at this point
test(accept_test.go): check ErrorHandler receives the Accept request
Show description for 38ae558
mafredri
committed
38ae558
View commit details
Copy full SHA for 38ae558
Browse repository at this point
test(accept_test.go): derive default responses from the rejection rows
Show description for 0f9f7d7
mafredri
committed
0f9f7d7
View commit details
Copy full SHA for 0f9f7d7
Browse repository at this point
test(accept_test.go): cover the Origin parse and no-host rejections
Show description for 5cf85d0
mafredri
committed
5cf85d0
View commit details
Copy full SHA for 5cf85d0
Browse repository at this point
docs(accept.go): say only that ErrorHandler err may hold server details
Show description for d01f39d
mafredri
committed
d01f39d
View commit details
Copy full SHA for d01f39d
Browse repository at this point
test(accept_test.go): restore why the server subtest uses a real server
Show description for b10f4ad
mafredri
committed
b10f4ad
View commit details
Copy full SHA for b10f4ad
Browse repository at this point
fix(accept): pass the OriginPatterns parse error to ErrorHandler
Show description for 56eccc2
mafredri
committed
56eccc2
View commit details
Copy full SHA for 56eccc2
Browse repository at this point
Commits on Nov 4, 2026
docs(accept.go): drop the ErrorHandler clause the doc already states
Show description for d6d333a
mafredri
committed
d6d333a
View commit details
Copy full SHA for d6d333a
Browse repository at this point
fix: name OriginPatterns in the invalid pattern error
Show description for 4b82827
mafredri
committed
4b82827
View commit details
Copy full SHA for 4b82827
Browse repository at this point
test(accept_test.go): fix the badOriginPattern comment
Show description for 09ddb1e
mafredri
committed
09ddb1e
View commit details
Copy full SHA for 09ddb1e
Browse repository at this point
docs: fix comment sentences that start lowercase or give code intent
Show description for 484bbe4
mafredri
committed
484bbe4
View commit details
Copy full SHA for 484bbe4
Browse repository at this point
docs(accept.go): rewrite the ErrorHandler doc
Show description for 1718326
mafredri
committed
1718326
View commit details
Copy full SHA for 1718326
Browse repository at this point
docs(accept.go): shorten the Accept error response sentence
Show description for 98a34ba
mafredri
committed
98a34ba
View commit details
Copy full SHA for 98a34ba
Browse repository at this point
You can’t perform that action at this time.
