Skip to content

Restore the 0.98% volume cap on the surplus fee for out-of-market limit orders. - #685

Merged
ropusaurio merged 1 commit into
mainfrom
diego/revert-surplus-fee-cap-removal
Nov 9, 2026
Merged

Restore the 0.98% volume cap on the surplus fee for out-of-market limit orders.#685
ropusaurio merged 1 commit into
mainfrom
diego/revert-surplus-fee-cap-removal

Conversation

@ropusaurio

@ropusaurio ropusaurio commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Restore the 0.98% volume cap on the surplus fee for out-of-market limit orders

Reverts #683, which changed the surplus fee cap on the Fees page from 0.98% to 99% of order volume.

What changes

The surplus fee on out-of-market limit orders goes back to what it was before #683:

  • Definition: 50% of surplus, capped at 0.98% of the total volume of the order (was 99%)
  • Fee calculation: surplus * 0.5 OR volume * 0.0098, whichever is lower (was volume * 0.99)

@ropusaurio
Revert "Document the effective removal of the surplus fee cap on limi…
33a2297 
…t orders (#683)"

This reverts commit 5c8b9c2 (#683),
restoring the 0.98% volume cap on the surplus fee for out-of-market limit orders.
@ropusaurio
ropusaurio requested a review from a team as a code owner November 9, 2026 16:54
@vercel

vercel Bot commented Nov 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 9, 2026 4:54pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 938afb40-7782-4c49-8108-455e5a7abde7
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ropusaurio ropusaurio added hotfix Labels PRs that should be applied into production right away and removed hotfix Labels PRs that should be applied into production right away labels Nov 9, 2026
@ropusaurio
ropusaurio merged commit d98a72f into main Nov 9, 2026
4 checks passed
@ropusaurio
ropusaurio deleted the diego/revert-surplus-fee-cap-removal branch November 9, 2026 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026

This branch was successfully deployed

1 active deployment
Preview — 33a2297f Deployed Nov 9, 2026 by vercel[bot]
View deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fleupold fleupold fleupold approved these changes
@tilacog tilacog tilacog approved these changes
@squadgazzz squadgazzz squadgazzz approved these changes
@AryanGodara AryanGodara AryanGodara approved these changes
@jmg-duarte jmg-duarte Awaiting requested review from jmg-duarte

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ropusaurio @fleupold @tilacog @squadgazzz @AryanGodara