Skip to content

Fix #765 (CI: run more testing on ubuntu-26.04 also) - #766

Merged
danmar merged 1 commit into
masterfrom
fix-765
Nov 18, 2026
Merged

danmar merged 1 commit into
masterfrom
fix-765

Conversation

@danmar

@danmar danmar commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@danmar danmar changed the title Fix #765 (CI: run tests on ubuntu-26.04) Fix #765 (CI: run more testing on ubuntu-26.04 also) Nov 18, 2026

@dmcppcheck dmcppcheck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review

I found no problems. The PR only changes .github/workflows/CI-unixish.yml. It adds ubuntu-26.04 and ubuntu-26.04-arm to the matrix for both clang++ and g++, and it removes man-db on ubuntu-26.04 as well, the same way as on ubuntu-24.04. No C++ code changes, so the preprocessor's behaviour, the API and performance are unaffected.

One thing to note, not a defect: the valgrind, libstdc++/libc++ debug-mode, ASan, UBSan and callgrind steps are still limited to ubuntu-24.04. The new 26.04 jobs therefore only run the plain build, the tests, selfcheck, the C++14 to C++23 builds and CMake. If the plan (as in the issue title, "run more testing") was to also run the sanitizers with the newer toolchains, those if: conditions would need extending.

Testing

This sandbox runs Ubuntu 24.04 (g++ 13.3, clang++ 18.1) with no network, so I could not run the workflow or try the newer compilers that ubuntu-26.04 ships.

  • In pr/, make -j8 testrunner simplecpp CXXOPTS=-Werror built cleanly.
  • ./testrunner: 0 failed (21 skipped, 14 todos).
  • python3 run-tests.py completed.
  • python3 -m pytest integration_test.py: 128 passed.
  • ./selfcheck.sh exited with 0.
  • I repeated the workflow's extra build steps locally: g++ with -Werror -std=c++14/c++17/c++20/c++2b all built, and so did clang++ with -Werror -std=c++2b.

The PR changes no preprocessor code, so I did not compare any output against gcc or clang.


Automated review of f239c79 by Claude. The pull request was built and tested locally.

@danmar
danmar merged commit 3ed6a6f into master Nov 18, 2026
84 of 87 checks passed
@danmar
danmar deleted the fix-765 branch November 18, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants