Repository navigation
Conversation
run-tests.py was never executed in the MSVC Windows workflow. Make it usable there: take the simplecpp path from SIMPLECPP_EXE_PATH (like integration_test.py) and normalize the backslash separators that glob returns on Windows so the skip/todo lists match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmcppcheck
left a comment
There was a problem hiding this comment.
AI review
The changes to run-tests.py are correct. On Linux, results are unchanged. In a simulation of Windows-style backslash paths from glob, the skip and todo lists still match.
The one concern is the new CI step. The title says windows-2022, but the step runs in every entry of the matrix (windows-2022, windows-2025, windows-11-arm × Release/Debug). The workflow never installs gcc or clang. It relies on whatever the runner image puts on PATH. If either compiler is missing on an image, run-tests.py stops at once with Failed to run tests: gcc compiler not found (exit code 1), and that job fails. windows-11-arm is the most likely to lack MinGW gcc. I could not check this here because there is no network.
I found no other problems.
Comments
| # | Comment | By | Where | Status |
|---|---|---|---|---|
| 1 | run-tests.py step runs on the whole matrix and depends on gcc/clang already being on PATH | AI review | .github/workflows/CI-windows.yml:74 |
🆕 New |
@danmar, please fix, resolve or reply to the open and new comments: #1.
Testing
- Built
/work/prwithmake -j8 testrunner simplecpp CXXOPTS=-Werror: OK. ./testrunner: exit 0.python3 run-tests.py: 176 tests, 21 skipped, 14 todos (0 fixed), 0 failed.python3 -m pytest integration_test.py: 128 passed../selfcheck.sh: exit 0.SIMPLECPP_EXE_PATH=/work/pr/simplecpp python3 run-tests.pyuses the given binary. WithSIMPLECPP_EXE_PATH=/nonexistentthe script fails withFileNotFoundError, as expected.- I simulated Windows paths with
/work/scratch/sim.py. It wrapsglob.globso that it returnstestsuite\...\x.c, maps the paths back to forward slashes for the subprocesses, and then runsrun-tests.pywithrunpy. Result: 176 tests, 21 skipped, 14 todos, 0 failed. So the newreplace('\\', '/')keeps the skip and todo matching working. - I could not run the Windows workflow itself: there is no Windows runner and no network here. Whether gcc and clang are on
PATHon each runner image is therefore unverified.
Automated review of ca373bc by Claude. The pull request was built and tested locally.
run-tests.py was never executed in the MSVC Windows workflow. Make it usable there: take the simplecpp path from SIMPLECPP_EXE_PATH (like integration_test.py) and normalize the backslash separators that glob returns on Windows so the skip/todo lists match.