Repository navigation
Move payment transaction approval and update to settlement and add settlement payout read methods - #58
Open
tuncaserhat wants to merge 1 commit into
Open
Move payment transaction approval and update to settlement and add settlement payout read methods#58tuncaserhat wants to merge 1 commit into
tuncaserhat wants to merge 1 commit into
Conversation
…ttlement payout read methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Payment transaction approval and update move to the settlement adapter, and the settlement reporting adapter gets read methods for the new payout model. Payout data is removed from payment responses; read it from the new payout methods instead.
Migration guide: https://developer.craftgate.io/migration/settlement-payout
Models:
PaymentTxPayoutResponse,PaymentTxPayoutListResponse,PayoutItem,PayoutCompletedItem(replacesPayoutCompletedTransaction),PayoutCompletedItemListResponse,SettlementRowResponse(replacesPayoutDetailResponse),SettlementRowItem,SearchPaymentTransactionPayoutsRequest,SearchPayoutCompletedItemsRequest(replacesSearchPayoutCompletedTransactionsRequest).PayoutApprovalStatus,PayoutItemSubject,SettlementRowItemSubject.TransactionPayoutStatusgainsELIMINATED_BY_FULLY_REFUND.payout,merchant_payout_amount,sub_merchant_member_payout_amount,sub_merchant_member_payout_ratefromPaymentTransaction;payout_statusfromReportingPaymentTransaction.PaymentTransactionResponse,Payout,PayoutStatus,PayoutDetailTransaction,PayoutCompletedTransactionListResponse.failed_reason_codeonPaymentTransactionApproval,settlement_row_idonPayoutRow.test_payment_sample.pytotest_settlement_sample.pyandtest_settlement_reporting_sample.py.Evidence
master;python -m compileall craftgate testspasses, the offline unit tests (tests.test_client_version,tests.test_idempotency, 18 tests) pass, and the changed sample modules import cleanly. Samples were not run against the sandbox.Merge Danger
Door: one-way
Blast Radius: merchants
Python has no compile step, so the breaks show at runtime after upgrading: importing a removed class raises
ImportError, calling the moved or renamed methods on the old adapter raisesAttributeError, and reading a removed field raisesAttributeError. Type checkers flag the same spots ahead of time. Nothing changes for code still on an older client version; the old endpoints keep working until their announced shutdown.