Skip to content

Return key ARN from KMS GetPublicKey - #26

Merged
damianh merged 2 commits into
mainfrom
dh/kms-get-public-key-arn
Nov 12, 2026
Merged

damianh merged 2 commits into
mainfrom
dh/kms-get-public-key-arn

Conversation

@damianh

@damianh damianh commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

KMS GetPublicKey returned the key UUID in KeyId, even when the key was looked up by ARN. AWS specifies that this field contains the key ARN.

The handler now returns rec.Arn. The existing GetPublicKey test now expects the ARN, and a new test covers lookup by ARN.


Read this PR faster    Follow each request

@coldtea-pr-lens

coldtea-pr-lens Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
  • Redraw · drawn at 2e2c9b7, the branch has moved on

Architecture

Walkthrough of Return Key ARN in KMS GetPublicKey responses, in three steps

Read this PR faster


Data flow

Data flow diagram for damianh/microstack at 2e2c9b7

Follow each request


Review

1 finding on the diff · reviewed 2e2c9b7

Tip

Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through
  • The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture… row. Drawing still runs as before
  • Set github.draw: on-demand in .github/pr-lens.yml and PR Lens stops drawing pull requests on its own. Comment @pr-lens draw on a pull request when you want that one drawn
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works
  • After a push, tick Redraw to draw the latest commit
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion
  • Set github.description: false in .github/pr-lens.yml to stop PR Lens adding buttons to your PR descriptions

Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it.  Star PR Lens on GitHub

damianh and others added 2 commits November 12, 2026 05:59
AWS specifies GetPublicKey.KeyId is the key ARN, regardless of how the key was identified.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign, Verify, Encrypt, Decrypt, GenerateDataKey, GenerateDataKeyWithoutPlaintext,
ScheduleKeyDeletion and CancelKeyDeletion now return the key ARN, matching
GetPublicKey and the AWS API reference.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@damianh
damianh force-pushed the dh/kms-get-public-key-arn branch from e68f27f to 21f4601 Compare November 12, 2026 04:59
@damianh
damianh merged commit d6469c2 into main Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant