Repository navigation
Return key ARN from KMS GetPublicKey - #26
Merged
Merged
Conversation
Architecture Data flow Review 1 finding on the diff · reviewed
|
AWS specifies GetPublicKey.KeyId is the key ARN, regardless of how the key was identified. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign, Verify, Encrypt, Decrypt, GenerateDataKey, GenerateDataKeyWithoutPlaintext, ScheduleKeyDeletion and CancelKeyDeletion now return the key ARN, matching GetPublicKey and the AWS API reference. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
damianh
force-pushed
the
dh/kms-get-public-key-arn
branch
from
November 12, 2026 04:59
e68f27f to
21f4601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KMS
GetPublicKeyreturned the key UUID inKeyId, even when the key was looked up by ARN. AWS specifies that this field contains the key ARN.The handler now returns
rec.Arn. The existingGetPublicKeytest now expects the ARN, and a new test covers lookup by ARN.