Repository navigation
Conversation
tox passes USERNAME, which getpass.getuser() reads on Windows (there is no pwd module to fall back on); the named-query test tolerates the log pgcli keeps open when its temporary directory is removed; the alias map is a plain file, since Windows cannot reopen an open NamedTemporaryFile by name.
Service containers do not run on Windows runners, so the job starts the PostgreSQL that the windows-latest image ships. behave stays Linux-only: it drives pgcli through pexpect.spawn, which Windows does not have.
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Nov 4, 2026
DiegoDAF
marked this pull request as ready for review
November 4, 2026 18:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dbaty 👋 !!!
Picks up #1442. Service containers do not run on Windows runners, so the job starts the PostgreSQL the
windows-latestimage ships. Unit tests only: behave drives pgcli throughpexpect.spawn, which Windows lacks.Three test fixes were needed: tox passes
USERNAME(getpass.getuser()has nopwdto fall back on), the\netest tolerates the open log at temp-dir cleanup, and the alias-map test writes a plain file (Windows cannot reopen an openNamedTemporaryFile).Green on my fork: 2808 passed, 1 skipped (setproctitle). https://github.com/DiegoDAF/pgcli.daf/actions/runs/41875648408