Repository navigation
fix: close owned Aptos clients on SDK shutdown - #21
Open
zakazaka95 wants to merge 1 commit into
Open
zakazaka95 wants to merge 1 commit into
zakazaka95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseSDK and DecibelReadDex each create an Aptos RestClient, which owns a separate httpx.AsyncClient. Their close methods leave that client open, including when exiting an async context manager.
Close the owned Aptos client as well. Keep cleanup running if another close fails, and preserve the existing rule that a caller-provided HTTP client stays open.
Validation on Python 3.11.15 with the frozen lockfile:
The lifecycle tests use real local HTTP client state without sending network requests. No live account, API key or transaction is needed.