Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/cmd/claude/claude.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ Subcommands:
depot claude secrets remove GITHUB_TOKEN`,
Args: cobra.ArbitraryArgs,
DisableFlagParsing: true,
Hidden: true,
RunE: func(cmd *cobra.Command, args []string) error {
// Not cobra's Deprecated: it prints to OutOrStderr, which is stdout when run as a Docker CLI plugin.
fmt.Fprintln(cmd.ErrOrStderr(), "depot claude is deprecated; use Depot Managed Agents instead: https://depot.dev/docs/managed-agents/claude-code-self-hosted")
if len(args) > 0 {
switch args[0] {
case "list-sessions":
Expand Down
38 changes: 38 additions & 0 deletions pkg/cmd/root/root_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,44 @@ func TestMergeRequestsAreHiddenButDirectlyAvailable(t *testing.T) {
}
}

func TestClaudeIsHiddenDeprecatedAndStillRuns(t *testing.T) {
cmd := NewCmdRoot("test-version", "test-date")
var out bytes.Buffer
cmd.SetOut(&out)
cmd.SetErr(&out)
for _, args := range [][]string{{"--help"}, {"__complete", ""}} {
out.Reset()
cmd.SetArgs(args)
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
if strings.Contains(out.String(), "claude") {
t.Fatalf("%v lists claude:\n%s", args, out.String())
}
}

claude, remaining, err := cmd.Find([]string{"claude"})
if err != nil || len(remaining) != 0 || claude.Name() != "claude" {
t.Fatalf("claude command not registered: %v, %v, %v", claude, remaining, err)
}

// Sandboxes and scripts parse stdout, and the Docker plugin wrapper sets its own stdout writer.
var stdout, stderr bytes.Buffer
cmd = NewCmdRoot("test-version", "test-date")
cmd.SetOut(&stdout)
cmd.SetErr(&stderr)
cmd.SetArgs([]string{"claude", "secrets"})
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
if !strings.Contains(stderr.String(), "use Depot Managed Agents instead") {
t.Errorf("stderr has no deprecation notice: %q", stderr.String())
}
if strings.Contains(stdout.String(), "deprecated") {
t.Errorf("deprecation notice on stdout: %q", stdout.String())
}
}

func TestBuildkitRegistryProxyIsHiddenAndRunsInternalCommand(t *testing.T) {
t.Setenv("CA_CERT", "invalid-base64!")
cmd := NewCmdRoot("test-version", "test-date")
Expand Down
Loading