Repository navigation
fix: bound item sitemap eligibility queries - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item sitemap requests exceeded the frontend deadline because eligibility filtering and sorting could scan the remaining catalog even for a small page. This change reads at most 1,000 ordered identities at a time, evaluates the shared eligibility predicate within that candidate range, and continues until limit+1 eligible items or the catalog end. The public item order, cursor, eligibility and hasNext contract stay unchanged.
V34 adds the matching (name, top_category, sub_category) index while retaining the primary key. Application version is 1.0.10.
Validation:
Each candidate window adds two queries; a sparse tail can require multiple windows. Production query timing and index build duration remain to be observed during the authorized rollout.