Repository navigation
feat: reuse constrain variables across solve - #70
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 99.52% 99.54% +0.01%
==========================================
Files 7 7
Lines 633 654 +21
==========================================
+ Hits 630 651 +21
Misses 3 3
🚀 New features to boost your workflow:
|
ycexiao
marked this pull request as ready for review
November 15, 2026 19:31
ycexiao
marked this pull request as draft
November 15, 2026 19:36
ycexiao
marked this pull request as ready for review
November 15, 2026 21:29
Contributor
Author
|
@sbillinge, it's ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Constrain variables are created in the
recipelevel per eachsolve. It is not removed so user can always access it.Thus clean
solveneeds to clear the session completely to remove those variables.This PR let
solveto reuse the existing constrain variables if they have the same name, and remove all constrain equations after the optimization. No restart is needed to start a cleansolve.Constrain variables are refer to the ones used to build constrain equations not the parameters being constrained.
What should the reviewer(s) do?