Repository navigation
fix: keep Python wrappers valid when ObjCryst++ releases sub-objects #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c4d4436
fix: keep Python wrappers valid when ObjCryst++ releases sub-objects
vincefn e886efc
chore: update extern/objcryst to merged vincefn/objcryst#106 (0f8dfef)
vincefn f4dbe1e
docs: shorten release-hooks news item
vincefn 0eed08c
chore: rename news item to PR number
vincefn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule objcryst
updated
14 files
| +5 −4 | ObjCryst/ObjCryst/Crystal.cpp | |
| +7 −2 | ObjCryst/ObjCryst/Crystal.h | |
| +15 −14 | ObjCryst/ObjCryst/IO.cpp | |
| +57 −9 | ObjCryst/ObjCryst/Molecule.cpp | |
| +32 −5 | ObjCryst/ObjCryst/Molecule.h | |
| +4 −3 | ObjCryst/ObjCryst/PowderPattern.cpp | |
| +2 −0 | ObjCryst/ObjCryst/PowderPattern.h | |
| +1 −1 | ObjCryst/ObjCryst/ScatteringCorr.cpp | |
| +49 −4 | ObjCryst/RefinableObj/RefinableObj.cpp | |
| +53 −0 | ObjCryst/RefinableObj/RefinableObj.h | |
| +114 −0 | test/unit/api_crystal.cpp | |
| +42 −0 | test/unit/api_molecule.cpp | |
| +63 −0 | test/unit/api_powderpattern.cpp | |
| +6 −0 | test/unit/run_unit_tests.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| **Added:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Changed:** | ||
|
|
||
| * Removed scatterers, scattering powers and molecule sub-objects are now deleted instead of leaked, unless still referenced from Python. | ||
|
|
||
| **Deprecated:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Removed:** | ||
|
|
||
| * <news item> | ||
|
|
||
| **Fixed:** | ||
|
|
||
| * Fix crashes (use-after-free, double free) and stale wrappers when ObjCryst++ deletes objects still referenced from Python (#121, #132). | ||
|
|
||
| **Security:** | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any other atom attributes that have be treated the same way, such as ADPs and occupancies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a Molecule we need this for the xyz atom coordinates because they are used as refinable parameters, so there are references pointing to them in the Molecule (not in a MolAtom because that class is not a RefinableObj). That's not the case for other parameters.
For ADPs these belong inside a ScatteringPower, and handled properly there.
Of course this is still a hook, the correct longer-term fix would be to implement reference counting in objcryst.