Repository navigation
Bidirectional build: prune joint states to a fixed point - #47
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_prune_to_stationary_supportmade two passes and finished by restricting the graph to the stationary support. That restriction can drop more joint states (masses belowtol), and nothing then re-checked that the survivors still had complete outgoing rows. With a truncated reverse machine (here 167 reverse states, smallest stationary mass 8.6e-12), validation failed withjoint masses from (2, 'CE') sum to 0.864643100703771.The prune now alternates "keep states with complete rows" and "keep the stationary support" until neither removes anything. On the failing 4-state survey process the build now succeeds (classified
truncated), with forward marginals matching to 1e-10 and the symbol law to 1e-11.Test plan
test_truncated_reverse_machine_prunes_to_complete_rows; it fails onmainand passes here.Made with Cursor