Repository navigation
Conversation
yosifkit
reviewed
Nov 13, 2026
| grep -F "listen_addresses = '*'" /usr/local/share/postgresql/postgresql.conf.sample | ||
|
|
||
| RUN install --verbose --directory --owner postgres --group postgres --mode 3777 /var/run/postgresql | ||
| RUN install --verbose --directory --owner postgres --group postgres --mode 3777 /run/postgresql |
Member
There was a problem hiding this comment.
This is moved to line 18, so it is no longer needed here, right?
Member
Author
There was a problem hiding this comment.
I'm so good at this. (updating)
This avoids the upstream behavior of resetting our carefully crafted "arbitrary user" permissions during the installation of `postgresql-common` -- alternatively, we could set the permissions after the install, but explicitly overriding the package behavior is cleaner. Also, move up the creation of `/run/postgresql` and finally apply the `/var/run` -> `/run` conversion that both Debian and Alpine applied long ago (no longer relying on the compatibility symlink).
yosifkit
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the upstream behavior of resetting our carefully crafted "arbitrary user" permissions during the installation of
postgresql-common-- alternatively, we could set the permissions after the install, but explicitly overriding the package behavior is cleaner.Also, move up the creation of
/run/postgresqland finally apply the/var/run->/runconversion that both Debian and Alpine applied long ago (no longer relying on the compatibility symlink).Fixes #1427