Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change removing agent-name pills from the TUI.
No open issues 🎉
What changed in this PR
Removes agent-name pills from assistant messages and reasoning blocks to reduce visual noise in the TUI, while preserving sender metadata and delegation-transition badges.
Changes:
- Removes badge rendering and previous-message tracking used to decide badge visibility.
- Simplifies rendering caches, code-block offsets, and reasoning-header hit testing.
- Updates tests and the chat snapshot for the badge-free layout.
| File | Description |
|---|---|
pkg/tui/components/transcript/transcript.go |
Removes previous-message plumbing from view creation. |
pkg/tui/components/reasoningblock/reasoningblock.go |
Removes agent badges and fixes the header position at line zero. |
pkg/tui/components/reasoningblock/reasoningblock_test.go |
Removes obsolete badge-rendering tests. |
pkg/tui/components/messages/messages.go |
Removes badge-selection logic and previous-message arguments. |
pkg/tui/components/messages/messages_test.go |
Checks badge-free streamed and restored messages, metadata, and layout. |
pkg/tui/components/message/message.go |
Removes sender pills and simplifies rendering caches and code-block offsets. |
e2e/tui/testdata/chat_basic_math.golden |
Updates the expected chat layout without the agent pill. |
Review effort: Balanced
|
Can you show screenshots with before/after please? |
aheritier
left a comment
There was a problem hiding this comment.
Thanks for cutting down the visual noise in the chat. I’d keep ordinary replies badge-free, but preserve a transcript cue when control changes hands and there’s no visible handoff row.
4355f1e to
1acd2d4
Compare
1acd2d4 to
009b6e5
Compare
@rumpl added some basic screenshots in the PR desc
@aheritier made the changes suggested, and ensured the handoff tool call remains outside reasoning blocks even if it happens during reasoning so it's easier to notice. now let me see what the bots have to say |
009b6e5 to
bcbc4ed
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Agent attribution still advances on failed transfers and loses visible transition anchors in transition-only histories, producing misleading or missing speaker labels.
2 open issues
4 resolved since last review
Review effort: Balanced
bcbc4ed to
e52a267
Compare
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
e52a267 to
889407b
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Speaker transitions are incorrectly created for whitespace-only replies and remain stale after reasoning is removed, leaving misleading attribution boundaries in the message view.
2 open issues
2 resolved since last review
Review effort: Balanced
| if i == len(m.messages)-1 && i > 0 { | ||
| prev := m.messages[i-1] | ||
| if prev.Type == types.MessageTypeAgentTransition && prev.Content == agentName { |
| if boundary := agentattribution.Boundary(m.messages, msg.Sender); boundary != nil { | ||
| return tea.Batch(m.addMessage(boundary), m.addMessage(msg)) |
|
these bots are not behaving. will reopen a cleaner solution to this |
|
maybe we should remove copilot @krissetto @rumpl It's very nitpicking cc @dgageot |
|
I'm honestly surprised Gordon isn't around here 😉 |

I don't think these are super useful, so here's a PR to remove those and make the TUI that tiny bit less noisy and remove a little bit of logic from the code.
Feel free to close the PR if in disagreement, i guess they could be somewhat useful for in-session handoffs
before:
after: