Repository navigation
Conversation
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking approval of the notification-layering change.
No open issues 🎉
What changed in this PR
This PR renders each TUI notification as a separate layer so shorter messages no longer obscure content beside them.
Changes:
- Give each notification its own clipped rendering and hit-test bounds.
- Prevent clicks from reaching controls covered by visible notifications, while preserving interaction through gaps.
- Add regression coverage for transcript visibility, resize controls, image clipping, and lean mode.
| File | Description |
|---|---|
pkg/tui/tui.go |
Compose individual notification layers and guard notification click handling. |
pkg/tui/sidebar_resize_test.go |
Verify resize guides remain visible through notification gaps. |
pkg/tui/notification_avoidance_test.go |
Test gap visibility and interaction, lean mode, and Kitty image clipping. |
pkg/tui/components/notification/notification.go |
Render separate notification layers and share clipped geometry with hit testing. |
pkg/tui/components/notification/notification_test.go |
Update layer assertions and test terminal-edge clipping. |
Review effort: Balanced
krissetto
marked this pull request as ready for review
November 21, 2026 23:31
krissetto
enabled auto-merge
November 21, 2026 23:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks of notifications were occupying the width of the widest message in the stack, and the height of the stack itself.
This means that if a short notification had a long one under it, the space between the long one and the short one was occupied by empty space that would cover anything underneath it (e.g. chat output)
This PR makes each notification use only the space it needs, regardless of the composition of the stack