Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Agent transitions are displayed inaccurately: forced handoffs lose visible attribution, including in restored sessions, while rejected handoffs persist as apparent successful switches.
2 open issues
What changed in this PR
This PR reduces visual noise in the TUI by removing agent badges from ordinary replies while retaining them on agent-transition cards.
Changes:
- Removes reply and reasoning badges, simplifying message construction and rendering.
- Keeps transfer and handoff cards visible in collapsed reasoning blocks.
- Updates sidebar spinner tracking and regression tests for agent transitions.
| File | Description |
|---|---|
pkg/tui/page/chat/runtime_events.go |
Routes agent metadata through sidebar event handling. |
pkg/tui/components/transcript/transcript.go |
Removes previous-message plumbing from view creation. |
pkg/tui/components/sidebar/sidebar.go |
Tracks spinner ownership across handoffs and transfers. |
pkg/tui/components/sidebar/agent_spinner_test.go |
Tests spinner ownership through agent transitions. |
pkg/tui/components/reasoningblock/reasoningblock.go |
Removes badges and preserves collapsed transition cards. |
pkg/tui/components/reasoningblock/reasoningblock_test.go |
Tests badge removal and persistent transition cards. |
pkg/tui/components/messages/stream_cancel_boundary_test.go |
Updates message construction in cancellation tests. |
pkg/tui/components/messages/messages.go |
Removes badge-selection logic and updates view construction. |
pkg/tui/components/messages/messages_test.go |
Tests badge-free replies and restored transition cards. |
pkg/tui/components/message/message.go |
Removes sender badges and simplifies rendering offsets and caching. |
pkg/tui/components/message/message_test.go |
Updates tests for the simplified constructor. |
pkg/tui/components/message/bench_test.go |
Updates benchmarks for the simplified constructor. |
pkg/tui/components/message/append_content_test.go |
Updates streaming-content tests for the simplified constructor. |
Review effort: Balanced
Assistant replies and reasoning blocks no longer render an agent badge. Agent changes stay visible through the transfer_task and handoff cards and the return transition, which keep their badges. Inside a collapsed reasoning block, completed transfer_task and handoff calls no longer fade out, so the boundary stays visible without expanding the block. Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
remove-reply-badges
branch
from
November 22, 2026 01:13
a2c1420 to
9be0e51
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Handoff guards hide genuine agent transitions in delegated tasks and completion-hook routes, leaving replies attributed to the wrong agent after reply badges are removed.
2 open issues
2 resolved since last review
Review effort: Balanced
| ) | ||
|
|
||
| func (p *chatPage) observeHandoffAgent(sessionID, agent string) tea.Cmd { | ||
| if p.streamCancelled || p.streamDepth == 0 || p.isSubSessionEvent(sessionID) || agent == "" { |
Comment on lines
+29
to
+30
| p.handoffAgent = msg.ToAgent | ||
| if msg.Phase == types.ForceHandoffPhase { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I don't think these badges are super useful, so here's a PR to remove 'em and make the TUI that tiny bit less noisy
Agent changes stay visible through the transfer_task and handoff cards and the return transition, which keep their badges (e.g. "A->B").
Inside a collapsed reasoning block, completed transfer_task and handoff calls no longer fade out, so the boundary stays visible without having to expand the block.
Feel free to close the PR if in disagreement
before:
after: