Repository navigation
chore(ci): update bats to 1.14.0 and checkout to v7 - #206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #176: CI runs the tests with bats 1.6.0, while the latest bats-core release and
Homebrew are at 1.14.0. Every CI run also has the warning
Node.js 20 is deprecated ... forced to run on Node.js 24: actions/checkout@v2, mig4/setup-bats@v1.Changes in
.github/workflows/ci.yml:mig4/setup-bats@v1(last release in 2020) withbats-version: 1.6.0is replaced with the official
bats-core/bats-action@4.1.0withbats-version: 1.14.0.latest: the action caches bats with the keybats-${{ inputs.bats-version }}, so withlatestthe key never changes and CIwould stay on the first cached version.
support-install,assert-install,detik-installandfile-installarefalse:the tests use their own
tests/test_helper.bash.github-token: the action downloads the bats tarball fromapi.github.com.actions/checkout@v2is replaced with@v7, the versionpages.ymlalready uses. The changes from v5 to v7 (Node.js 24, credentials in aseparate file, no fork PR checkout on
pull_request_target/workflow_run) do notaffect this workflow.
openspec: theupdate-ci-batschange (proposal, design, tasks) withskip_specs: true, not archived yet. The behavior ofgh-md-tocdoes not change.The tests and the other workflows do not change.
Not included:
dockerimage.yml(actions/checkout@v2,docker/build-push-action@v1),Dependabot, the remote tests that fail now and then on github.com pages (#179).
Testing
make testwith bats 1.14.0 locally: all 76 tests pass (macOS).yamllint -d relaxedandactionlint1.7.12 report nothing onci.yml. Before thechange,
actionlintreportedthe runner of "actions/checkout@v2" action is too old to run on GitHub Actions.