Repository navigation
Conversation
Not up to standards ⛔
|
Laurettta
force-pushed
the
7.x.x/hotfix/group-by-npe
branch
from
November 17, 2026 10:20
52a9a0f to
1472341
Compare
Contributor
|
@Laurettta Although this change does stop the NPE but the result is not what we expected, the expected output of let $x := (10, 20, 30)
group by $y := $x < 30
return
$xIs 10
20
30Convert this PR into a draft and see if you can fix the implementation. |
Laurettta
marked this pull request as draft
November 17, 2026 13:29
Author
|
Thanks @marmoure, I have converted it to a draft and I will work on getting the expected |
Laurettta
force-pushed
the
7.x.x/hotfix/group-by-npe
branch
from
November 17, 2026 15:10
1472341 to
89bbccc
Compare
Author
|
@marmoure I have pushed a fix. The query now returns |
Laurettta
marked this pull request as ready for review
November 17, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LetExprnow callspreEvalon the next clause, likeForExprdoes, sogroup byafterletno longer throws an NPE.Closes eXist-db/exist#5236