Repository navigation
Conversation
Record the component name and Vue's info string instead of the whole instance, and accept Vue's errorHandler signature so the documented app.config.errorHandler assignment compiles under strict TypeScript.
Nothing in the try block could throw, and a missing AsyncStorage native module fails when the package is imported, so the fallback and its log message never ran. AsyncStorage remains a required peer dependency.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
Repeated query parameters still produce array-valued query_string entries in violation of the string-valued contract, and the main skill retains contradictory Expo plugin setup guidance.
2 open issues
What changed in this PR
This PR fixes request and error reporting in the Vue and Node SDKs, removes unreachable React Native storage fallback code, and clarifies Expo setup.
Changes:
- Reports Vue component names instead of serializing component instances, accepts unknown errors, and adds handler tests.
- Captures Node query parameters from
request.queryrather than route parameters, with regression tests. - Removes the ineffective AsyncStorage fallback and documents the Expo plugin as optional.
| File | Description |
|---|---|
vitest.config.ts |
Adds the Vue test project. |
packages/vue/test/ExceptionlessErrorHandler.test.ts |
Tests component metadata and error handling. |
packages/vue/src/index.ts |
Replaces instance serialization with component names. |
packages/vue/README.md |
Documents captured error metadata. |
packages/react-native/src/ReactNativeExceptionlessClient.ts |
Removes unreachable storage fallback code. |
packages/react-native/README.md |
Clarifies optional Expo plugin usage. |
packages/node/test/plugins/NodeRequestInfoPlugin.test.ts |
Tests query capture and missing queries. |
packages/node/src/plugins/NodeRequestInfoPlugin.ts |
Reads query data from request.query. |
.agents/skills/exceptionless-javascript/references/client-vue.md |
Documents Vue error metadata. |
.agents/skills/exceptionless-javascript/references/client-react-native.md |
Updates Expo setup and autolinking troubleshooting. |
Review effort: Balanced
|
|
||
| if (config.includeQueryString) { | ||
| const json = stringify(request.params, exclusions); | ||
| const json = stringify(request.query, exclusions); |
| ``` | ||
|
|
||
| For Expo development or standalone builds, add the config plugin: | ||
| No config plugin is required: the native crash reporter pod is linked by autolinking. The optional config plugin currently makes no native changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small, verified bug fixes.
ExceptionlessErrorHandlerput the whole component instance on the event, which froze the page while serializing. It now records the component name andinfo. Its signature takeserr: unknown, soapp.config.errorHandler = ExceptionlessErrorHandlercompiles under strict TypeScript.query_stringfrom route params. It now usesrequest.query.Checks:
npm run build,npm run lintandnpm test(351 tests) pass. Adds avuetest project with tests for the handler.