Repository navigation
fix(verify): explain a missing API checkout instead of naming the npx cache - #370
Merged
Merged
Conversation
… cache Run from a scaffolded project through npx, verify guessed the API source as a sibling of the CLI's install folder and failed with a path inside the npm cache. The error now says verify is a contributor tool, where to clone the API, and to run seamless check for a generated project. From an npm install it skips the sibling guess unless SEAMLESS_API_DIR is set, and verify --help leads with the same pointer. Closes #367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #367.
Run from a scaffolded project through npx,
seamless verifyguessed the auth API source as a sibling of the CLI's install folder and failed with a path inside the npm cache, with no hint that verify is a contributor tool.seamless checkfor a project made byinit.node_modulespath) it no longer guesses a sibling checkout unlessSEAMLESS_API_DIRis set, so no cache path is printed.seamless verify --helpopens with the same pointer tocheck.Tests cover the npx path,
SEAMLESS_API_DIRoverriding it, and the sibling default for a linked CLI. Build, 2126 tests and coverage pass.