Repository navigation
Add hybrid function calling sample - #2855
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Hybrid Function Calling feature, adding the necessary ViewModel, UI screen, state representation, and navigation routing to support testing function calling tools across on-device, hybrid, and cloud inference modes. The feedback highlights opportunities to improve robustness and consistency, specifically by using safe casting to prevent potential exceptions during JSON parsing, ensuring the streaming generation path handles automatic function calling consistently with the unary path, and avoiding redundant model downloads in the UI when the selected option has not changed.
VinayGuthal
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Oct 30, 2026
Tested at firebase/quickstart-android#2855 ### Description Adds support for function calling when generating content using on-device and hybrid (`PREFER_ON_DEVICE`) inference modes, following the ML Kit GenAI Prompt APIs. When function calling tools are supplied, `OnDeviceGenerativeModelProvider` verifies that the underlying on-device model supports function calling via `isFunctionCallingAvailable()`. If function calling is not supported by the on-device model or if unsupported non-function tools (such as Google Search or Code Execution) are configured, a `FirebaseAIOnDeviceNotAvailableException` is raised, triggering automatic fallback to cloud inference in `PREFER_ON_DEVICE` mode. ### Summary of Changes - **`gradle/libs.versions.toml`**: - Updated `genaiPrompt` to `1.0.0-beta5` and `genaiSchema` to `1.0.0-alpha2`. - **`ai-logic/firebase-ai-ondevice-interop`**: - Added `FunctionDeclaration` and `FunctionSchema` interop data structures. - Added `FunctionCallPart` and `FunctionResponsePart` to `Part.kt`. - Added `functionCalls: List<FunctionCallPart>` to `Candidate`. - Added `tools: List<FunctionDeclaration>?` to `GenerateContentRequest`. - Added `suspend fun isFunctionCallingAvailable(): Boolean` to `GenerativeModel`. - Updated `api.txt` and `CHANGELOG.md`. - **`ai-logic/firebase-ai-ondevice`**: - Implemented `GenerativeModelImpl.isFunctionCallingAvailable()` delegating to ML Kit's `getAvailableFeatures().contains(Feature.FUNCTION_CALLING)`. - Added converters in `Converters.kt` for `FunctionCallPart`, `FunctionResponsePart`, `FunctionDeclaration`, and `FunctionSchema` to/from ML Kit equivalents. - Mapped candidate function calls in `GenerateContentResponse.toInterop()`. - Updated `api.txt` and `CHANGELOG.md`. - Added unit test coverage in `GenerativeModelImplTest` and `ConvertersTest`. - **`ai-logic/firebase-ai`**: - Added `tools: List<Tool>? = null` to `OnDeviceConfig` to allow configuring tools for on-device inference, defaulting to model-level tools when omitted. - Forwarded tools configuration in `GenerativeModel` to `OnDeviceGenerativeModelProvider`. - Updated `Candidate.fromInterop` to convert interop function calls into `FunctionCallPart` instances. - In `OnDeviceGenerativeModelProvider`: - Checks `onDeviceModel.isFunctionCallingAvailable()` when function declarations are provided. - Throws `FirebaseAIOnDeviceNotAvailableException` if non-function tools are passed to on-device inference or if function calling is unsupported. - Converts `FunctionCallPart` and `FunctionResponsePart` in conversation history. - Maps function declarations and auto-function declarations into interop schemas. - Updated `api.txt` and `CHANGELOG.md`. - Added unit tests in `OnDeviceGenerativeModelProviderTests` covering tool execution, candidate mapping, multi-turn history with function responses, streaming support, and cloud fallback behavior. ### Testing - `./gradlew :ai-logic:firebase-ai-ondevice-interop:check` - `./gradlew :ai-logic:firebase-ai-ondevice:check` - `./gradlew :ai-logic:firebase-ai:check` - `./gradlew spotlessCheck` --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…i/feature/hybrid/FunctionCallingViewModel.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
rlazo
reviewed
Nov 2, 2026
rlazo
reviewed
Nov 2, 2026
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new "Hybrid Function Calling" sample feature to the application, adding the FunctionCallingViewModel, FunctionCallingScreen, and associated UI state to demonstrate function calling across On-Device, Hybrid, and Cloud inference modes. It also updates the Firebase AI dependencies in gradle/libs.versions.toml to newer versions. The feedback identifies a duplicate import of BidiViewModel in MainActivity.kt that should be cleaned up.
Contributor
|
It's not building |
rlazo
reviewed
Nov 10, 2026
| title = "Hybrid System Instructions", | ||
| description = """Test systemInstruction (single text, multiple text parts, and non-text part validation) | ||
| | across On-Device, Hybrid, and Cloud inference modes.""".trimMargin(), | ||
| | across On-Device, Hybrid, and Cloud inference modes. |
rlazo
reviewed
Nov 10, 2026
rlazo
reviewed
Nov 10, 2026
rlazo
reviewed
Nov 10, 2026
rlazo
reviewed
Nov 10, 2026
rlazo
reviewed
Nov 10, 2026
rlazo
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new sample screen to test function calling tools across on-device, hybrid (
PREFER_ON_DEVICE), and cloud inference modes. This sample complements the function calling support added in firebase-android-sdk #8758.Features
FunctionDeclaration): DefinesfetchWeather(city, state, date), inspects returnedFunctionCallPartentries, executes the local tool, and sendsFunctionResponsePartto resolve the multi-turn exchange.AutoFunctionDeclaration): Validates automatic tool invocation handled directly by the SDK.Tool.googleSearch()): Demonstrates validation behavior and automatic cloud fallback when non-function tools are used with hybrid inference.ONLY_ON_DEVICE,PREFER_ON_DEVICE,ONLY_IN_CLOUD).generateContent) and streaming (generateContentStream) generation methods.ON_DEVICEvsIN_CLOUD).Summary of Changes
gradle/libs.versions.toml:firebase-aito18.2.0andfirebase-ai-ondeviceto16.0.0-beta08.firebase-ai/app:FunctionCallingViewModel.kt,FunctionCallingUiState.kt, andFunctionCallingScreen.ktundercom.google.firebase.quickstart.ai.FUNCTION_CALLINGinScreenType(Sample.kt).HYBRIDandTOOLS_FCcategories inFirebaseAISamples.kt.MainActivity.kt.Testing
./gradlew :app:assembleDebug./gradlew ktlintCheck