You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Android Gradle Plugin (AGP) to version 9.5.1 and upgrades FirebaseUI dependencies to version 10.0.0 across several modules. The reviewer feedback suggests centralizing these FirebaseUI dependency versions in the Gradle Version Catalog (libs.versions.toml) instead of hardcoding them in individual build files, which improves project maintainability.
The reason will be displayed to describe this comment to others. Learn more.
To maintain a single source of truth and avoid duplicating the version 10.0.0 across multiple build.gradle.kts files (auth, database, firestore, and functions), define the FirebaseUI version and libraries in this central Version Catalog (libs.versions.toml).\n\nYou can then declare the libraries in the [libraries] section of this file:\ntoml\nfirebase-ui-auth = { module = "com.firebaseui:firebase-ui-auth", version.ref = "firebaseUi" }\nfirebase-ui-database = { module = "com.firebaseui:firebase-ui-database", version.ref = "firebaseUi" }\n\nAnd reference them in your build.gradle.kts files like:\nkotlin\nimplementation(libs.firebase.ui.auth)\n
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought to you by your friendly Repository Gardener.