Skip to content

Auto-update dependencies. - #2856

Open
dpebot wants to merge 1 commit into
masterfrom
dpebot-repositorygardener
Open

dpebot wants to merge 1 commit into
masterfrom
dpebot-repositorygardener

Conversation

@dpebot

@dpebot dpebot commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Brought to you by your friendly Repository Gardener.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android Gradle Plugin (AGP) to version 9.5.1 and upgrades FirebaseUI dependencies to version 10.0.0 across several modules. The reviewer feedback suggests centralizing these FirebaseUI dependency versions in the Gradle Version Catalog (libs.versions.toml) instead of hardcoding them in individual build files, which improves project maintainability.

Comment thread gradle/libs.versions.toml
[versions]
activityCompose = "1.13.0"
agp = "9.4.1"
agp = "9.5.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain a single source of truth and avoid duplicating the version 10.0.0 across multiple build.gradle.kts files (auth, database, firestore, and functions), define the FirebaseUI version and libraries in this central Version Catalog (libs.versions.toml).\n\nYou can then declare the libraries in the [libraries] section of this file:\ntoml\nfirebase-ui-auth = { module = "com.firebaseui:firebase-ui-auth", version.ref = "firebaseUi" }\nfirebase-ui-database = { module = "com.firebaseui:firebase-ui-database", version.ref = "firebaseUi" }\n\nAnd reference them in your build.gradle.kts files like:\nkotlin\nimplementation(libs.firebase.ui.auth)\n

Suggested change
agp = "9.5.1"
agp = "9.5.1"\nfirebaseUi = "10.0.0"

Comment thread auth/app/build.gradle.kts
// Firebase UI
// Used in FirebaseUIActivity.
implementation("com.firebaseui:firebase-ui-auth:9.1.1")
implementation("com.firebaseui:firebase-ui-auth:10.0.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.

    implementation(libs.firebase.ui.auth)

implementation("com.google.firebase:firebase-auth")

implementation("com.firebaseui:firebase-ui-database:9.1.1")
implementation("com.firebaseui:firebase-ui-database:10.0.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.

    implementation(libs.firebase.ui.database)


// FirebaseUI (for authentication)
implementation("com.firebaseui:firebase-ui-auth:9.1.1")
implementation("com.firebaseui:firebase-ui-auth:10.0.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.

    implementation(libs.firebase.ui.auth)


// Firebase UI
implementation("com.firebaseui:firebase-ui-auth:9.1.1")
implementation("com.firebaseui:firebase-ui-auth:10.0.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding dependency versions in individual module build.gradle.kts files. Instead, use the central Version Catalog (libs.versions.toml) to manage the dependency version and reference it here.

    implementation(libs.firebase.ui.auth)

@dpebot
dpebot force-pushed the dpebot-repositorygardener branch 2 times, most recently from 775658c to 29140d1 Compare November 12, 2026 08:55
@dpebot
dpebot force-pushed the dpebot-repositorygardener branch from 29140d1 to c31eebc Compare November 13, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant