Repository navigation
chore: prevent auto-update of FirebaseUI and AGP - #2857
Open
thatfiredev wants to merge 1 commit into
Open
thatfiredev wants to merge 1 commit into
thatfiredev wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates build.gradle.kts to block updates for com.firebaseui and introduces a helper function isBuggyAGP to reject buggy Android Gradle Plugin (AGP) versions (<= 9.5.1) during dependency updates. Feedback points out that the current version parsing logic in isBuggyAGP is prone to a NumberFormatException when encountering pre-release versions containing non-numeric characters, and that the matching logic is overly broad, potentially blocking unrelated com.android. libraries. A safer parsing and matching implementation is suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent these 2 libraries from being bumped by @dpebot :