Repository navigation
Conversation
Laravel 11+ ships a native Request::array(), which wins over core-api's macro of that name and stops it splitting comma-separated values. Needs core-api with inputArray.
This was referenced Nov 6, 2026
Open
Member
Author
|
Superseded by #12, which contains this branch's commits. Closing without merging: on its own this resolves against Laravel 10, which Composer 2.11 now refuses. The branch is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calls core-api's
inputArray()instead ofarray()(1 file changed, 1 insertion(+), 1 deletion(-)).Laravel 11+ ships a native
Request::array(), and native methods win over macros. On Laravel 12, core-api's comma-splitting macro silently stops running, so?sort=a,bstyle parameters become one value. In the spike,GET /int/v1/places?sort=-created_at,namereturned 500 on Laravel 12 and 200 on Laravel 10. The macro body is unchanged, so there's no behaviour change.Testing
Local on Laravel 10, against core-api's rename branch: 108 passed.
OidcResponse::array()is unrelated and unchanged.Merge order
Needs a core-api release containing fleetbase/core-api#331. Until then, CI resolving the released core-api has no
inputArraymacro.