Repository navigation
Resource entries: button in the first screen, shorter creator lists, linked clusters - #1136
Open
LukasWallrich wants to merge 2 commits into
Open
LukasWallrich wants to merge 2 commits into
LukasWallrich wants to merge 2 commits into
Conversation
- Show six creators and a disclosure with the rest, so the button stays in the first phone screen. - Name the destination host beside "Open this resource", with the external-link icon. - Link clusters in the details card to their cluster pages. - Show the material type as a plain label instead of a chip. - Put the entry before the details card in source order; the grid keeps the card in the left column on desktop, and on phones it comes before Previous/Next, replacing the one-line summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 1 changed file(s)! 🎉 |
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="assets/css/doors/article.css">
<violation number="1" location="assets/css/doors/article.css:168">
P3: The resource keyword spacing rule is overridden by the later generic margin shorthand, so resource pages do not receive the intended 24px gap above Keywords. Increase the selector specificity or move this override below the generic rule.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| .article-layout .byline-more>summary{display:inline-block;margin-inline-start:.3em;color:var(--link);font-weight:600;text-decoration:underline;text-underline-offset:3px;cursor:pointer} | ||
| .article-layout .byline-more>summary:hover{color:var(--ink)} | ||
| .article-layout .byline-more>p{margin:6px 0 0} | ||
| .article-layout-resource .resource-keywords{margin-top:24px} |
Contributor
There was a problem hiding this comment.
P3: The resource keyword spacing rule is overridden by the later generic margin shorthand, so resource pages do not receive the intended 24px gap above Keywords. Increase the selector specificity or move this override below the generic rule.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At assets/css/doors/article.css, line 168:
<comment>The resource keyword spacing rule is overridden by the later generic margin shorthand, so resource pages do not receive the intended 24px gap above Keywords. Increase the selector specificity or move this override below the generic rule.</comment>
<file context>
@@ -154,8 +154,31 @@ main:lang(ar) .article-layout .article-style,main:lang(ar) .article-layout .arti
+.article-layout .byline-more>summary{display:inline-block;margin-inline-start:.3em;color:var(--link);font-weight:600;text-decoration:underline;text-underline-offset:3px;cursor:pointer}
+.article-layout .byline-more>summary:hover{color:var(--ink)}
+.article-layout .byline-more>p{margin:6px 0 0}
+.article-layout-resource .resource-keywords{margin-top:24px}
+.article-layout-resource .article-card dd a{color:var(--link);text-decoration:underline;text-underline-offset:3px}
+.article-layout-resource>.article-foot{margin-top:0}
</file context>
Suggested change
| .article-layout-resource .resource-keywords{margin-top:24px} | |
| .article-layout.article-layout-resource .resource-keywords{margin-top:24px} |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource entries are the site's largest page family (1,473 pages), and often the page people land on from search. In the first round under the new design guide (#1135), Sol and Opus scored them 7 and 6. The main problems they found:
What changes for visitors:
Decisions to review
Checks:
check_seo_html.pyand the source rules pass, and the unit tests pass. The page audit (overflow, text under 15 px, contrast, line length) is clean on the four sample pages at 390 and 1440 px. CI runs the full design check and axe.Based on
rebrand-doors, which now includes the latestmain.199 creators, phone: six names, then "and 96 more". The button is now in the first screen, with its destination beside it. (This build lists 102 creators, so the disclosure says 96 more.)
199 creators, desktop
Short entry, phone: a plain type label, the destination beside the button, and one details card before Previous and Next instead of a summary line plus the card
Short entry, desktop: a plain type label and the destination beside the button
Details card, desktop: the cluster links to its cluster page
Created with Claude Opus 5.5 in Claude Code; reviewed by GPT-6.1 Sol and Claude Opus 5.5.
🤖 Generated with Claude Code
Summary by cubic
Reworks resource entry pages so the main button stays in the first phone screen and reading order puts the entry before the details card.
forrt.org.Decisions to review
forrt.orglinks show the site name without the external-link icon.Written for commit da89a98. Summary will update on new commits.