Repository navigation
fix(carlife): handle desktop requests and prevent microphone shutdown deadlocks - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CarLife's return-to-desktop command now opens the paired browser's settings for the active, ready projection session. Requests before streaming or during shutdown are ignored.
Microphone shutdown now uses a separate PCM queue lock so the stop callback can wait for capture to exit without blocking its final PCM callback. Session cleanup runs microphone shutdown on the cleanup thread and continues closing the transport and executors if the microphone stop callback fails.
Includes two focused commits on top of the previously merged CarLink/CarLife integration, with regression coverage for desktop requests, in-flight PCM during stop/close, capture-initiated shutdown, and cleanup failures.
Validation:
:common:testDebugUnitTest --tests 'moe.feng.wheelplay.carlife.*' --tests 'moe.feng.wheelplay.projection.carlife.*').git diff --checkpassed.