Skip to content

fix(carlife): handle desktop requests and prevent microphone shutdown deadlocks - #64

Merged
fython merged 2 commits into
fython:mainfrom
seasonyuu:codex/carlife-followups
Nov 19, 2026
Merged

fython merged 2 commits into
fython:mainfrom
seasonyuu:codex/carlife-followups

Conversation

@seasonyuu

Copy link
Copy Markdown
Contributor

CarLife's return-to-desktop command now opens the paired browser's settings for the active, ready projection session. Requests before streaming or during shutdown are ignored.

Microphone shutdown now uses a separate PCM queue lock so the stop callback can wait for capture to exit without blocking its final PCM callback. Session cleanup runs microphone shutdown on the cleanup thread and continues closing the transport and executors if the microphone stop callback fails.

Includes two focused commits on top of the previously merged CarLink/CarLife integration, with regression coverage for desktop requests, in-flight PCM during stop/close, capture-initiated shutdown, and cleanup failures.

Validation:

  • 98 CarLife protocol and projection unit tests passed (:common:testDebugUnitTest --tests 'moe.feng.wheelplay.carlife.*' --tests 'moe.feng.wheelplay.projection.carlife.*').
  • git diff --check passed.
  • The desktop-request version was installed and launched on a vivo V2547A; the microphone shutdown fix has not yet been deployed to the device, and end-to-end projection behavior remains unverified.

@fython
fython merged commit 7d525d7 into fython:main Nov 19, 2026
4 checks passed
@seasonyuu
seasonyuu deleted the codex/carlife-followups branch November 19, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants