Repository navigation
feat(node): add ClickHouse instrumentation - #26211
Open
adityareddy-dev wants to merge 4 commits into
Open
adityareddy-dev wants to merge 4 commits into
adityareddy-dev wants to merge 4 commits into
Conversation
adityareddy-dev
changed the title
adityareddy-dev
marked this pull request as ready for review
November 9, 2026 19:10
adityareddy-dev
requested review from
JPeer264,
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team
November 9, 2026 19:10
adityareddy-dev
requested review from
Lms24 and
msonnb
and removed request for
a team
November 9, 2026 19:10
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a75f505. Configure here.
The sanitizer stopped looking for the FORMAT clause once an INSERT reached SELECT, so rows read through input() stayed in db.query.text. FORMAT is now the data clause anywhere at the top level of an INSERT, unless the token before it expects a name, as in SELECT format or FROM format.
Contributor
Author
|
@JPeer264 can you approve the workflows on the latest push? |
Member
|
@adityareddy-dev done. Btw I'll review that next week as something else came in this week. Also I'm not too familiar with clickhouse, so I have to go a bit deeper into it to give a proper review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Add DB spans for
@clickhouse/clientthrough Orchestrion, following the maintainer's go-ahead. Rejected calls set span status and still reach the caller without a separate captured error.How to review: Start with the ClickHouse config and integration. The sanitizer is extracted with its existing exports preserved.
Unsure about: Clients with an explicit custom tracer can emit additional spans. The integration leaves that option alone.
Closes #15966