Repository navigation
Conversation
The embedded compression worker is minified with `minifySync`, which doesn't pick up `transform.target` and defaults to esnext. It shipped `||=`/`&&=` (ES2021), so the worker fails to start on ES2020-only browsers. Because it is embedded as a string, `lint:es-compatibility` never saw it, so the build now parses it as ES2020. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 126190f (PR test merge using develop at 88cc648) Against: 88cc648 (develop) · base run #66002 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 25 successful. See the run.
Successful checks
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8e114ef. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The replay compression worker gets minified with
minifySync, which doesn't pick uptransform.targetand defaults to esnext. The worker code in our bundles currently contains ES2021 syntax (t||={},this.v&&=…), so it fails to start on ES2020-only browsers (e.g. Safari 13–14, Chrome 80–84).lint:es-compatibilitynever caught it because the worker is embedded as a string. The build now parses the minified worker as ES2020 and fails if it isn't. The size change is negligible (+9 B raw, −2 B gzip).How to review: Single file,
packages/replay-worker/rollup.worker.config.mjs. I confirmed the new check fails the build without thetargetfix.🤖 Generated with Claude Code