Repository navigation
ref(tracing): Narrow TransactionMetadata parentSamplingRate type to drop PHPStan baseline entry - #2332
Open
sentry-junior[bot] wants to merge 1 commit into
Open
ref(tracing): Narrow TransactionMetadata parentSamplingRate type to drop PHPStan baseline entry#2332sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
…rop PHPStan baseline entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the PHPStan baseline entry
property.unusedTypeforTransactionMetadata::$parentSamplingRate("is never assigned int so it can be removed from the property type").The private property's
@varsaidfloat|int|null, but the only writers (the constructor andsetParentSamplingRate()) take?float, andgetParentSamplingRate()returns?float. The docblock now saysfloat|nullto match.This is safe because it only changes a docblock on a private property. Runtime behavior and the public API stay the same.
The sibling
$sampleRandentry has the same shape. It's left for a separate PR to keep this one to a single baseline entry.via automation
sched_f05c2f3e9355ecbdd933cf87d44ec5c6· Run IDsched_f05c2f3e9355ecbdd933cf87d44ec5c6:1794128400000.--
View Session [Sentry]