Repository navigation
[bot] Merge master/d4e429d0 into rel/dev - #1955
Merged
Merged
Conversation
The dashboard evaluator read only a tab's top-level widgets. A chart moved into a container counted as missing, and an item could not state a container's children, their order or its direction, so creating a group, stacking it or swapping inside it had nothing to be scored by. Every chart check now reads the leaf widgets inside containers; a switcher stays one widget. A widget is a container when it carries `container` or `sections`, because the AAC converter writes `sections` only for a non-empty container. A `layout` entry can name a container by `container_path` and state its `layout_direction`, and a section can list its exact children with `widgets`: chart ids, authored chart titles, notes and whole switchers. Entries are keyed by tab and path, so one tab can carry several. The same tab and path twice, and an entry without tab beside a named one, are still refused; `filter_bar` keeps its one-entry-per-tab rule. Documents without containers and existing layout items score as before. jira: GDAI-2416 risk: low
feat(gooddata-eval): score widgets inside dashboard containers
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1955 +/- ##
===========================================
+ Coverage 86.55% 86.60% +0.04%
===========================================
Files 349 349
Lines 27015 27115 +100
===========================================
+ Hits 23383 23482 +99
- Misses 3632 3633 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to d4e429d (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/43443436670).